Skip to content

Use The_Comms_Arena in particle communication. #4175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atmyers merged 4 commits into from
Oct 23, 2024
Merged

Use The_Comms_Arena in particle communication. #4175

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b10711d
Use The_Comms_Arena in particle communication.
atmyers Sep 30, 2024
ed3e186
Merge branch 'development' into particle_comms_arena
atmyers Sep 30, 2024
22fef8c
use The_Comms_Arena only when gpu aware MPI is ON
atmyers Oct 22, 2024
f168bec
also make change in NeighborParticleContainer
atmyers Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Src/Particle/AMReX_NeighborParticles.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ protected:
ParticleCopyPlan neighbor_copy_plan;

amrex::PODVector<char, PolymorphicArenaAllocator<char> > snd_buffer;
amrex::Gpu::DeviceVector<char> rcv_buffer;
amrex::PODVector<char, PolymorphicArenaAllocator<char> > rcv_buffer;

Gpu::PinnedVector<char> pinned_snd_buffer;
Gpu::PinnedVector<char> pinned_rcv_buffer;
Expand Down
4 changes: 4 additions & 0 deletions Src/Particle/AMReX_NeighborParticlesGPUImpl.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,6 +255,10 @@ updateNeighborsGPU (bool boundary_neighbors_only)
}

clearNeighbors();

snd_buffer.setArena(The_Comms_Arena());
rcv_buffer.setArena(The_Comms_Arena());

packBuffer(*this, neighbor_copy_op, neighbor_copy_plan, snd_buffer);
if (ParallelDescriptor::UseGpuAwareMpi())
{
Expand Down
4 changes: 3 additions & 1 deletion Src/Particle/AMReX_ParticleContainerI.H
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1355,7 +1355,9 @@ ParticleContainer_impl<ParticleType, NArrayReal, NArrayInt, Allocator, CellAssig
h_redistribute_real_comp, local);

amrex::PODVector<char, PolymorphicArenaAllocator<char> > snd_buffer;
Gpu::DeviceVector<char> rcv_buffer;
amrex::PODVector<char, PolymorphicArenaAllocator<char> > rcv_buffer;
snd_buffer.setArena(The_Comms_Arena());
rcv_buffer.setArena(The_Comms_Arena());

packBuffer(*this, op, plan, snd_buffer);

Expand Down