refactor-fixes: coderrabbit fixes

Author: smokeyScraper

backend/app/api/v1/integrations.py

@@ -7,7 +7,7 @@
     IntegrationListResponse,
     IntegrationStatusResponse
 )
-from app.services.integration_service import integration_service
+from app.services.integration_service import integration_service, NotFoundError
 from app.core.dependencies import get_current_user
 
 router = APIRouter()
@@ -24,10 +24,7 @@ async def create_integration(
     except ValueError as e:
         raise HTTPException(status_code=status.HTTP_400_BAD_REQUEST, detail=str(e))
     except Exception as e:
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to create integration: {str(e)}"
-        )
+        raise HTTPException(status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail=str(e)) from e
 
 
 @router.get("/", response_model=IntegrationListResponse)
@@ -37,10 +34,7 @@ async def list_integrations(user_id: UUID = Depends(get_current_user)):
         integrations = await integration_service.get_integrations(user_id)
         return IntegrationListResponse(integrations=integrations, total=len(integrations))
     except Exception as e:
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to list integrations: {str(e)}"
-        )
+        raise HTTPException(status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail=str(e)) from e
 
 
 @router.get("/status/{platform}", response_model=IntegrationStatusResponse)
@@ -52,11 +46,7 @@ async def get_integration_status(
     try:
         return await integration_service.get_integration_status(user_id, platform)
     except Exception as e:
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to get integration status: {str(e)}"
-        )
-
+        raise HTTPException(status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail=str(e)) from e
 
 @router.get("/{integration_id}", response_model=IntegrationResponse)
 async def get_integration(
@@ -74,14 +64,8 @@ async def get_integration(
             )
 
         return integration
-    except HTTPException:
-        raise
     except Exception as e:
-        raise HTTPException(
-            status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
-            detail=f"Failed to get integration: {str(e)}"
-        )
-
+        raise HTTPException(status_code=status.HTTP_500_INTERNAL_SERVER_ERROR, detail=str(e)) from e
 
 @router.put("/{integration_id}", response_model=IntegrationResponse)
 async def update_integration(
@@ -92,14 +76,15 @@ async def update_integration(
     """Update an existing integration."""
     try:
         return await integration_service.update_integration(user_id, integration_id, request)
+    except NotFoundError as e:
+        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e)) from e
     except HTTPException:
         raise
     except Exception as e:
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail=f"Failed to update integration: {str(e)}"
-        )
-
+        ) from e
 
 @router.delete("/{integration_id}", status_code=status.HTTP_204_NO_CONTENT)
 async def delete_integration(
@@ -109,10 +94,12 @@ async def delete_integration(
     """Delete an integration."""
     try:
         await integration_service.delete_integration(user_id, integration_id)
+    except NotFoundError as e:
+        raise HTTPException(status_code=status.HTTP_404_NOT_FOUND, detail=str(e)) from e
     except HTTPException:
         raise
     except Exception as e:
         raise HTTPException(
             status_code=status.HTTP_500_INTERNAL_SERVER_ERROR,
             detail=f"Failed to delete integration: {str(e)}"
-        )
+        ) from e

backend/app/core/dependencies.py

@@ -47,7 +47,7 @@ async def get_current_user(authorization: str = Header(None)) -> UUID:
     try:
         supabase = get_supabase_client()
         # Verify the token and get user
-        user_response = await supabase.auth.get_user(token)
+        user_response = supabase.auth.get_user(token)
 
         if not user_response or not user_response.user:
             raise HTTPException(
@@ -61,9 +61,9 @@ async def get_current_user(authorization: str = Header(None)) -> UUID:
     except HTTPException:
         raise
     except Exception as e:
-        logger.error(f"Authentication error: {str(e)}")
+        logger.exception("Authentication error")
         raise HTTPException(
             status_code=status.HTTP_401_UNAUTHORIZED,
             detail="Authentication failed",
             headers={"WWW-Authenticate": "Bearer"},
-        )
+        ) from e

backend/app/services/integration_service.py

@@ -7,7 +7,8 @@
     IntegrationCreateRequest,
     IntegrationUpdateRequest,
     IntegrationResponse,
-    IntegrationStatusResponse
+    IntegrationStatusResponse,
+    NotFoundError
 )
 
 logger = logging.getLogger(__name__)
@@ -64,7 +65,7 @@ async def create_integration(
             return IntegrationResponse(**result.data[0])
 
         except Exception as e:
-            logger.error(f"Error creating integration: {str(e)}")
+            logger.exception("Error creating integration")
             raise
 
     async def get_integrations(self, user_id: UUID) -> List[IntegrationResponse]:
@@ -78,7 +79,7 @@ async def get_integrations(self, user_id: UUID) -> List[IntegrationResponse]:
             return [IntegrationResponse(**item) for item in result.data]
 
         except Exception as e:
-            logger.error(f"Error getting integrations: {str(e)}")
+            logger.exception("Error getting integrations")
             raise
 
     async def get_integration(self, user_id: UUID, integration_id: UUID) -> Optional[IntegrationResponse]:
@@ -96,7 +97,7 @@ async def get_integration(self, user_id: UUID, integration_id: UUID) -> Optional
             return IntegrationResponse(**result.data[0])
 
         except Exception as e:
-            logger.error(f"Error getting integration: {str(e)}")
+            logger.exception("Error getting integration")
             raise
 
     async def get_integration_by_platform(
@@ -118,7 +119,7 @@ async def get_integration_by_platform(
             return IntegrationResponse(**result.data[0])
 
         except Exception as e:
-            logger.error(f"Error getting integration by platform: {str(e)}")
+            logger.exception("Error getting integration by platform")
             raise
 
     async def update_integration(
@@ -140,12 +141,14 @@ async def update_integration(
             if request.config is not None:
                 update_data["config"] = request.config
 
+            existing = await self.get_integration(user_id, integration_id)
+            if not existing:
+                raise NotFoundError("Integration not found")
+
             if request.organization_link is not None:
-                if "config" not in update_data:
-                    # Get existing config first
-                    existing = await self.get_integration(user_id, integration_id)
-                    update_data["config"] = existing.config or {}
-                update_data["config"]["organization_link"] = request.organization_link
+                base_config = (update_data.get("config") or existing.config or {}).copy()
+                base_config["organization_link"] = request.organization_link
+                update_data["config"] = base_config
 
             result = await self.supabase.table("organization_integrations")\
                 .update(update_data)\
@@ -161,7 +164,7 @@ async def update_integration(
             return IntegrationResponse(**result.data[0])
 
         except Exception as e:
-            logger.error(f"Error updating integration: {str(e)}")
+            logger.exception("Error updating integration")
             raise
 
     async def delete_integration(self, user_id: UUID, integration_id: UUID) -> bool:
@@ -178,7 +181,7 @@ async def delete_integration(self, user_id: UUID, integration_id: UUID) -> bool:
             return True
 
         except Exception as e:
-            logger.error(f"Error deleting integration: {str(e)}")
+            logger.exception("Error deleting integration")
             raise
 
     async def get_integration_status(
@@ -204,7 +207,7 @@ async def get_integration_status(
             )
 
         except Exception as e:
-            logger.error(f"Error getting integration status: {str(e)}")
+            logger.exception("Error getting integration status")
             raise
 
     async def get_all_integrations_for_platform(self, platform: str) -> List[IntegrationResponse]:
@@ -219,7 +222,7 @@ async def get_all_integrations_for_platform(self, platform: str) -> List[Integra
             return [IntegrationResponse(**item) for item in result.data]
 
         except Exception as e:
-            logger.error(f"Error getting all integrations for platform: {str(e)}")
+            logger.exception("Error getting all integrations for platform")
             raise
 
 

backend/database/01_create_integration_tables.sql

@@ -51,7 +51,8 @@ CREATE POLICY "Users can create their own integrations"
 CREATE POLICY "Users can update their own integrations"
     ON organization_integrations
     FOR UPDATE
-    USING (auth.uid() = user_id);
+    USING (auth.uid() = user_id)
+    WITH CHECK (auth.uid() = user_id);
 
 CREATE POLICY "Users can delete their own integrations"
     ON organization_integrations

frontend/.env example

@@ -2,4 +2,4 @@ VITE_SUPABASE_URL=YOUR SUPABASE URL
 VITE_BASE_URL=http://localhost:5173/
 VITE_SUPABASE_KEY=YOUR SUPABASE ANON KEY
 VITE_BACKEND_URL=http://localhost:8000
-VITE_DISCORD_BOT_INVITE_URL=https://discord.com/oauth2/authorize?client_id==&permissions==&integration_type=0&scope=bot+applications.commands
+VITE_DISCORD_BOT_INVITE_URL=https://discord.com/oauth2/authorize?client_id=YOUR_CLIENT_ID&permissions=YOUR_PERMISSIONS&integration_type=0&scope=bot+applications.commands