Old hash form cache #16830
Merged
Old hash form cache #16830
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aka old hash Co-Authored-By: npc-riddlah <[email protected]>
4 tasks
catboxanon
approved these changes
Feb 10, 2025
w-e-w
added a commit
to w-e-w/stable-diffusion-webui
that referenced
this pull request
May 2, 2025
* use not equal when comparing mtime * cache partial hash aka old hash Co-Authored-By: npc-riddlah <[email protected]> --------- Co-authored-by: npc-riddlah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
currently every time when the SD models scanned (on webui start up, model refresh)
it re-calculate the old partial hash (which we don't use) this massive waste
I see no reason not to cache it like we do for
hahses.sha256()additional change
use not equal when comparing mtime
I can't think of reason why the mtime check for sha256 is
>and not!=, so I change it to!=Checklist: