Skip to content

Conversation

@tdavidovicNV
Copy link
Contributor

This brings GenSlang tests to be in line with GenGlsl, and disables the writing of tested shaders to disk.

The main motivation is that the tests (both Slang and GLSL) actually currently produce invalid code for the NG_lightcompoundtest node, which is confusing.

@kwokcb
Copy link
Contributor

kwokcb commented Nov 26, 2025

Can we add (to Slang) update (GLSL) addSkipNodeDefs() tester override to include ND_lightcompoundtest ?

@tdavidovicNV
Copy link
Contributor Author

Can we add (to Slang) update (GLSL) addSkipNodeDefs() tester override to include ND_lightcompoundtest ?

I am sorry, I am not exactly sure what you mean by those two parentheses.
I've added it to the GenSlang addSkipNodeDefs(). Should I add it to GenGlsl as well?

@tdavidovicNV tdavidovicNV force-pushed the dev/tdavidovic/disable_genslang_file_generation branch from 85ff6df to 2a8f2f4 Compare November 27, 2025 06:52
@jstone-lucasfilm
Copy link
Member

@tdavidovicNV @kwokcb Let's keep this change focused on Slang, and we can address the GLSL exception in a separate PR. Based on recent discussions on the MaterialX Slack, I'm getting the sense that we'll ultimately want to remove the light compound node entirely, as it's no longer used by any of the teams in our community, so that may end up being the next step for that specific exception in Slang and GLSL render tests.

Copy link
Member

@jstone-lucasfilm jstone-lucasfilm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, @tdavidovicNV!

@jstone-lucasfilm jstone-lucasfilm changed the title Disabled the genslang test generating files. This matches genglsl. Align saving of generated Slang shaders with GLSL Dec 1, 2025
@jstone-lucasfilm jstone-lucasfilm changed the title Align saving of generated Slang shaders with GLSL Align writing of generated Slang shaders with GLSL Dec 1, 2025
@jstone-lucasfilm jstone-lucasfilm merged commit 5c66561 into AcademySoftwareFoundation:main Dec 1, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants