removed focus workaround to enable keyboard navigation of dropdown options #340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@AhmedLSayed9 thanks for the great library! what do you think about merging this? |
Author
|
Actually looks like this fix only works on <=2.3.9. i haven't started using beta 3.* yet so it seems something different may be going on. I also made a patch for 2.3.9 so maybe it could be released as 2.3.10? https://github.com/willsmanley/dropdown_button2/tree/2.3.9_patch |
|
I've tested this fix as well it is working fine. |
Owner
|
@Umair-Manzoor-47 See the conversation at the linked issue. |
|
Please merge! |
Owner
|
@EliaTolin |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #339