Skip to content

Changed behavior in extract_arch_from_text #115

@black-sliver

Description

@black-sliver

The last change 07aa21f
changes the strncmp to a length that does not include the NUL byte. This effectively changes the comparison to a "startswith" rather than a comparison.

I believe this is not intentional, because I believe you can never get the arm_aarch64 codepath now.

    const char* archname = "arm_aarch64";
    printf("%d\n", g_ascii_strncasecmp("arm", archname, 3)); // prints 0

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions