Merge pull request #386 from AtomLinter/steelbrain/remove-timeout

Remove worker on timeout

Author: steelbrain

CHANGELOG.md

@@ -1,3 +1,7 @@
+### v5.2.7
+
+* Remove timeout from worker spawn
+
 ### v5.2.6
 
 * Fix file exception on Windows resolution (#354)

lib/main.js

@@ -83,12 +83,6 @@ export default {
           return
         }
 
-        if (this.worker === null) {
-          // Abort if worker is not yet ready
-          atom.notifications.addError('Linter-ESLint: Not ready, please try again')
-          return
-        }
-
         this.worker.request('FIX', {
           fileDir,
           filePath,
@@ -103,10 +97,6 @@ export default {
       }
     }))
 
-    // Reason: I (steelbrain) have observed that if we spawn a
-    // process while atom is starting up, it can increase startup
-    // time by several seconds, But if we do this after 5 seconds,
-    // we barely feel a thing.
     const initializeWorker = () => {
       if (this.active) {
         const { child, worker, subscription } = spawnWorker()
@@ -121,7 +111,7 @@ export default {
         })
       }
     }
-    setTimeout(initializeWorker, 5 * 1000)
+    initializeWorker()
   },
   deactivate() {
     this.active = false
@@ -143,15 +133,6 @@ export default {
         const fileDir = Path.dirname(filePath)
         const showRule = atom.config.get('linter-eslint.showRuleIdInMessage')
 
-        if (this.worker === null) {
-          return Promise.resolve([{
-            filePath,
-            type: 'Info',
-            text: 'Worker initialization is delayed. Please try saving or typing to begin linting.',
-            range: Helpers.rangeFromLineNumber(textEditor, 0)
-          }])
-        }
-
         return this.worker.request('JOB', {
           fileDir,
           filePath,