Commit message ignored because of a matching ignore pattern

Author: not-an-aardvark

lib/worker.js

@@ -23,6 +23,20 @@ function _interopRequireDefault(obj) { return obj && obj.__esModule ? obj : { de
 
 process.title = 'linter-eslint helper';
 
+const ignoredMessages = [
+// V1
+'File ignored because of your .eslintignore file. Use --no-ignore to override.',
+// V2
+'File ignored because of a matching ignore pattern. Use --no-ignore to override.',
+// V2.11.1
+'File ignored because of a matching ignore pattern. Use "--no-ignore" to override.',
+// supress warning that the current file is ignored by eslint by default
+'File ignored by default.  Use a negated ignore pattern (like "--ignore-pattern \'!<relative' + '/path/to/filename>\'") to override.', 'File ignored by default. Use "--ignore-pattern \'!node_modules/*\'" to override.', 'File ignored by default. Use "--ignore-pattern \'!bower_components/*\'" to override.'];
+
+function shouldBeReported(problem) {
+  return !ignoredMessages.includes(problem.message);
+}
+
 function lintJob(_ref) {
   let cliEngineOptions = _ref.cliEngineOptions,
       contents = _ref.contents,
@@ -36,15 +50,14 @@ function lintJob(_ref) {
 
 function fixJob(_ref2) {
   let cliEngineOptions = _ref2.cliEngineOptions,
-      contents = _ref2.contents,
       eslint = _ref2.eslint,
       filePath = _ref2.filePath;
 
-  const report = lintJob({ cliEngineOptions, contents, eslint, filePath });
+  const report = lintJob({ cliEngineOptions, eslint, filePath });
 
   eslint.CLIEngine.outputFixes(report);
 
-  if (!report.results.length || !report.results[0].messages.length) {
+  if (!report.results.length || !report.results[0].messages.filter(shouldBeReported).length) {
     return 'Linter-ESLint: Fix complete.';
   }
   return 'Linter-ESLint: Fix attempt complete, but linting errors remain.';
@@ -74,9 +87,9 @@ function fixJob(_ref2) {
     job.response = [];
   } else if (type === 'lint') {
     const report = lintJob({ cliEngineOptions, contents, eslint, filePath });
-    job.response = report.results.length ? report.results[0].messages : [];
+    job.response = report.results.length ? report.results[0].messages.filter(shouldBeReported) : [];
   } else if (type === 'fix') {
-    job.response = fixJob({ cliEngineOptions, contents, eslint, filePath });
+    job.response = fixJob({ cliEngineOptions, eslint, filePath });
   } else if (type === 'debug') {
     const modulesDir = _path2.default.dirname((0, _atomLinter.findCached)(fileDir, 'node_modules/eslint') || '');
     job.response = Helpers.findESLintDirectory(modulesDir, config);

spec/linter-eslint-spec.js

@@ -162,13 +162,21 @@ describe('The eslint provider for Linter', () => {
     beforeEach(() => {
       atom.config.set('linter-eslint.disableEslintIgnore', false)
     })
-    it('will not give warnings for the file', () => {
+    it('will not give warnings when linting the file', () => {
       waitsForPromise(() =>
         atom.workspace.open(ignoredPath).then(editor =>
           lint(editor).then(messages => expect(messages.length).toBe(0))
         )
       )
     })
+
+    it('will not give warnings when autofixing the file', () => {
+      waitsForPromise(() =>
+        atom.workspace.open(ignoredPath).then(editor =>
+          fix(editor).then(result => expect(result).toBe('Linter-ESLint: Fix complete.'))
+        )
+      )
+    })
   })
 
   describe('fixes errors', () => {

src/worker.js

@@ -10,6 +10,24 @@ import { isConfigAtHomeRoot } from './is-config-at-home-root'
 
 process.title = 'linter-eslint helper'
 
+const ignoredMessages = [
+  // V1
+  'File ignored because of your .eslintignore file. Use --no-ignore to override.',
+  // V2
+  'File ignored because of a matching ignore pattern. Use --no-ignore to override.',
+  // V2.11.1
+  'File ignored because of a matching ignore pattern. Use "--no-ignore" to override.',
+  // supress warning that the current file is ignored by eslint by default
+  'File ignored by default.  Use a negated ignore pattern (like "--ignore-pattern \'!<relative'
+    + '/path/to/filename>\'") to override.',
+  'File ignored by default. Use "--ignore-pattern \'!node_modules/*\'" to override.',
+  'File ignored by default. Use "--ignore-pattern \'!bower_components/*\'" to override.',
+]
+
+function shouldBeReported(problem) {
+  return !ignoredMessages.includes(problem.message)
+}
+
 function lintJob({ cliEngineOptions, contents, eslint, filePath }) {
   const cliEngine = new eslint.CLIEngine(cliEngineOptions)
 
@@ -18,12 +36,12 @@ function lintJob({ cliEngineOptions, contents, eslint, filePath }) {
     : cliEngine.executeOnFiles([filePath])
 }
 
-function fixJob({ cliEngineOptions, contents, eslint, filePath }) {
-  const report = lintJob({ cliEngineOptions, contents, eslint, filePath })
+function fixJob({ cliEngineOptions, eslint, filePath }) {
+  const report = lintJob({ cliEngineOptions, eslint, filePath })
 
   eslint.CLIEngine.outputFixes(report)
 
-  if (!report.results.length || !report.results[0].messages.length) {
+  if (!report.results.length || !report.results[0].messages.filter(shouldBeReported).length) {
     return 'Linter-ESLint: Fix complete.'
   }
   return 'Linter-ESLint: Fix attempt complete, but linting errors remain.'
@@ -48,9 +66,9 @@ create().onRequest('job', ({ contents, type, config, filePath, projectPath, rule
     job.response = []
   } else if (type === 'lint') {
     const report = lintJob({ cliEngineOptions, contents, eslint, filePath })
-    job.response = report.results.length ? report.results[0].messages : []
+    job.response = report.results.length ? report.results[0].messages.filter(shouldBeReported) : []
   } else if (type === 'fix') {
-    job.response = fixJob({ cliEngineOptions, contents, eslint, filePath })
+    job.response = fixJob({ cliEngineOptions, eslint, filePath })
   } else if (type === 'debug') {
     const modulesDir = Path.dirname(findCached(fileDir, 'node_modules/eslint') || '')
     job.response = Helpers.findESLintDirectory(modulesDir, config)