nicer error reporting when svg width/height missing

Author: chearon

src/Image.cc

@@ -1482,6 +1482,11 @@ Image::loadSVGFromBuffer(uint8_t *buf, unsigned len) {
   width = naturalWidth = d_width;
   height = naturalHeight = d_height;
 
+  if (width <= 0 || height <= 0) {
+    this->errorInfo.set("Width and height must be set on the svg element");
+    return CAIRO_STATUS_READ_ERROR;
+  }
+
   return renderSVGToSurface();
 }
 

test/canvas.test.js

@@ -2516,10 +2516,17 @@ describe('Canvas', function () {
 
   describe('loadImage', function () {
     it('doesn\'t crash when you don\'t specify width and height', async function () {
+      const err = {name: "Error"};
+
+      // TODO: remove this when we have a static build or something
+      if (os.platform() !== 'win32') {
+        err.message = "Width and height must be set on the svg element";
+      }
+
       await assert.rejects(async () => {
         const svg = `<svg xmlns="http://www.w3.org/2000/svg"><path d="M1,1"/></svg>`;
         await loadImage(Buffer.from(svg));
-      });
+      }, err);
     });
   });
 })