nicer error reporting when svg width/height missing

Author: chearon

src/Image.cc

@@ -1482,6 +1482,11 @@ Image::loadSVGFromBuffer(uint8_t *buf, unsigned len) {
   width = naturalWidth = d_width;
   height = naturalHeight = d_height;
 
+  if (width <= 0 || height <= 0) {
+    this->errorInfo.set("Width and height must be set on the svg element");
+    return CAIRO_STATUS_READ_ERROR;
+  }
+
   return renderSVGToSurface();
 }
 

test/canvas.test.js

@@ -2519,6 +2519,9 @@ describe('Canvas', function () {
       await assert.rejects(async () => {
         const svg = `<svg xmlns="http://www.w3.org/2000/svg"><path d="M1,1"/></svg>`;
         await loadImage(Buffer.from(svg));
+      }, {
+        name: "Error",
+        message: "Width and height must be set on the svg element"
       });
     });
   });