Skip to content

Commit db2c5e5

Browse files
authored
Checkout: fix mobile visual inconsistencies (#106906)
* Fix vertical alignment of Purchase Details header * Set max-width for inputs * Set input font color * Set input colors to textColorDark * Update input border-radius * Consistently set top bar height in Checkout * Fix summary alignment, padding, and border radius * Fix vertical alignment of summary title
1 parent 3d4492d commit db2c5e5

File tree

8 files changed

+15
-15
lines changed

8 files changed

+15
-15
lines changed

client/layout/masterbar/style.scss

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@ body.is-mobile-app-view {
110110
background-color: var(--studio-white);
111111
border-bottom: none 0;
112112
color: var(--color-checkout-masterbar-text);
113-
height: var(--masterbar-height);
113+
height: var(--masterbar-checkout-height);
114114
position: absolute;
115115
padding-inline-end: 1.5em;
116116

@@ -119,10 +119,6 @@ body.is-mobile-app-view {
119119
padding-inline-start: 1.5em;
120120
}
121121

122-
@include break-mobile {
123-
height: var(--masterbar-checkout-height);
124-
}
125-
126122
@include breakpoint-deprecated( ">960px" ) {
127123
background-color: var(--color-checkout-masterbar-background);
128124
}

client/my-sites/checkout/src/components/checkout-main-content.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1108,6 +1108,7 @@ const CheckoutSummaryTitleContent = styled.span`
11081108
font-size: 16px;
11091109
font-weight: ${ ( props ) => props.theme.weights.bold };
11101110
justify-content: space-between;
1111+
align-items: center;
11111112
margin: 0 auto;
11121113
padding: 24px;
11131114
max-width: 600px;
@@ -1119,6 +1120,7 @@ const CheckoutSummaryTitleContent = styled.span`
11191120

11201121
const CheckoutSummaryTitle = styled.span`
11211122
display: flex;
1123+
align-items: center;
11221124
`;
11231125

11241126
const CheckoutSummaryTitleIcon = styled( Gridicon )`
@@ -1531,7 +1533,7 @@ const WPCheckoutCompletedMainContent = styled.div`
15311533
const WPCheckoutSidebarContent = styled.div`
15321534
background: ${ ( props ) => props.theme.colors.background };
15331535
grid-area: sidebar-content;
1534-
margin-top: var( --masterbar-height );
1536+
margin-top: var( --masterbar-checkout-height );
15351537
15361538
@media ( ${ ( props ) => props.theme.breakpoints.bigPhoneUp } ) {
15371539
margin-top: var( --masterbar-checkout-height );

client/my-sites/checkout/src/components/checkout-sidebar-plan-upsell/style.scss

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
}
55

66
.promo-card.checkout-sidebar-plan-upsell {
7-
padding: 20px;
7+
padding: 24px;
88
}
99

1010
.promo-card.checkout-sidebar-plan-upsell .action-panel__title {
@@ -18,6 +18,7 @@
1818
.promo-card {
1919
max-width: 384px;
2020
width: 100%;
21+
border-radius: 3px;
2122
}
2223
.promo-card .action-panel__body {
2324
overflow: visible;

client/my-sites/checkout/src/components/secondary-cart-promotions.tsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -33,14 +33,12 @@ const UpsellWrapper = styled.div`
3333
.cart__upsell-header {
3434
border-top: 1px solid ${ ( props ) => props.theme.colors.borderColorLight };
3535
box-shadow: none;
36-
padding-left: 20px;
37-
padding-right: 20px;
36+
padding-left: 24px;
37+
padding-right: 24px;
3838
3939
@media ( ${ ( props ) => props.theme.breakpoints.desktopUp } ) {
4040
border-top: none;
4141
border-bottom: 1px solid ${ ( props ) => props.theme.colors.borderColorLight };
42-
padding-left: 24px;
43-
padding-right: 24px;
4442
}
4543
4644
.section-header__label {
@@ -51,7 +49,7 @@ const UpsellWrapper = styled.div`
5149
}
5250
5351
.cart__upsell-body {
54-
padding: 0 20px 20px;
52+
padding: 0 24px 24px;
5553
font-size: 14px;
5654
5755
@media ( ${ ( props ) => props.theme.breakpoints.desktopUp } ) {

client/my-sites/checkout/src/components/wp-checkout-order-summary.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -773,9 +773,9 @@ const pulse = keyframes`
773773

774774
const CheckoutSummaryCard = styled.div`
775775
border: none;
776-
border-radius: 4px;
776+
border-radius: 3px;
777777
background: #fff;
778-
padding: 28px;
778+
padding: 24px;
779779
box-shadow:
780780
0 3px 1px rgb( 0 0 0 / 4% ),
781781
0 3px 8px rgb( 0 0 0 / 12% );

client/my-sites/checkout/src/components/wp-contact-form.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,8 @@ const BillingFormFields = styled.div< BillingFormFieldsProps >`
2626
input[type='search'].form-text-input,
2727
.form-select,
2828
.form-fieldset.contact-details-form-fields select {
29-
border-radius: 3px;
29+
border-radius: 2px;
30+
color: ${ ( props ) => props.theme.colors.textColorDark };
3031
}
3132
3233
& .form-input-validation {

packages/composite-checkout/src/components/field.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ const Label = styled.label< { disabled?: boolean } & LabelHTMLAttributes< HTMLLa
1818
const Input = styled.input<
1919
{ isError?: boolean; icon?: React.ReactNode } & InputHTMLAttributes< HTMLInputElement >
2020
>`
21+
color: ${ ( props ) => props.theme.colors.textColorDark };
2122
display: block;
2223
width: 100%;
2324
box-sizing: border-box;

packages/wpcom-checkout/src/field.tsx

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -113,6 +113,7 @@ const Input = styled.input< {
113113
line-height: 1.5;
114114
font-size: 14px;
115115
padding: 7px 14px;
116+
max-width: 100%;
116117
117118
::-webkit-inner-spin-button,
118119
::-webkit-outer-spin-button {

0 commit comments

Comments
 (0)