[bugfix] Release pipeline updated as per java jdk #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ag-ramachandran
requested changes
Jul 17, 2024
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| with: | ||
| args: | | ||
| staging/kusto-spark_${{ steps.get_version.outputs.SPARK_VERSION }}_${{ steps.get_version.outputs.SCALA_VERSION }}-${{ steps.get_version.outputs.VERSION }}-jar-with-dependencies.jar |
There was a problem hiding this comment.
This name is not right, there is no longer with-dependencies jar
| cp connector/.flattened-pom.xml staging/kusto-spark_$sparkversion_$scalaversion-$version.pom | ||
| - name: Github Release | ||
| uses: anton-yurchenko/git-release@v5.0.1 | ||
| uses: docker://antonyurchenko/git-release:v6 |
There was a problem hiding this comment.
Why use an external release plugin
https://docs.github.com/en/actions/publishing-packages/publishing-java-packages-with-maven#publishing-packages-to-github-packages can this be used ?
| destination_folder: kusto/spark/${{ steps.get_version.outputs.SPARK_VERSION }}_${{ steps.get_version.outputs.SCALA_VERSION }}-${{ steps.get_version.outputs.VERSION }} | ||
| delete_if_exists: true | ||
| delete_if_exists: true | ||
| if: ${{ github.event_name == 'push' || (github.event_name == 'workflow_dispatch' && github.event.inputs.upload_to_azure == 'true') }} |
There was a problem hiding this comment.
Correct me here, why is this needed .. We need to do this only on GH release right and not on push perhaps ?
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
ag-ramachandran
temporarily deployed
to
build
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[Add a description of your pull request here]
Future Release Comment
[Add description of your change, to include in the next release]
[Delete any or all irrelevant sections, e.g. if your change does not warrant a release comment at all]
Breaking Changes:
Features:
Fixes: