Skip to content

Conversation

@azure-sdk
Copy link
Collaborator

@azure-sdk azure-sdk commented Nov 10, 2025

Configurations: 'specification/netapp/resource-manager/Microsoft.NetApp/NetApp/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '303503695c531db175f23f8e09da2193eff8f701' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5555237 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=10303b69-cead-f011-bbd3-6045bd0569b8 Submitted by: [email protected]

Release Plan Details

…pp/NetApp/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '303503695c531db175f23f8e09da2193eff8f701' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5555237 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
@github-actions github-actions bot added the Mgmt This issue is related to a management-plane library. label Nov 10, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 10, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

com.azure.resourcemanager:azure-resourcemanager-netapp


#### `models.CapacityPoolList` was removed

#### `models.SubscriptionQuotaItem` was removed
Copy link
Member

@weidongxu-microsoft weidongxu-microsoft Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Main break is this, renamed to QuotaItem. Let us know if service want to accept it and potentially break user.

Other breaks listed here are expected

  • ##List is not used by user and hence does not need to be visible
  • Output-only model does not need to have setter methods
  • A few break on RelationshipStatus is already discussed in TypeSpec PR and is expected
  • 1 Float -> Integer is also discussed
  • A few Float -> Double, if service wish, we can add an emitter option to avoid these

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add @clientame decorator to avoid breaking?

@clientName("NetAppSubscriptionQuotaItem", "csharp")
@clientName("SubscriptionQuotaItem", "java")
@parentResource(SubscriptionLocationResource)
model QuotaItem is Azure.ResourceManager.Pro

Copy link
Member

@weidongxu-microsoft weidongxu-microsoft Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can rename in client.tsp. I will add it, and refresh this PR.

(but the question is then why we renamed this to QuotaItem in Swagger, while we still need SubscriptionQuotaItem in SDK...)

…pp/NetApp/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '756699c964e06e55640096504c33ee4828d027fb' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5561685 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Mgmt This issue is related to a management-plane library.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants