-
Notifications
You must be signed in to change notification settings - Fork 2.1k
[AutoPR azure-resourcemanager-netapp]-generated-from-SDK Generation - Java-5555237 #47222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[AutoPR azure-resourcemanager-netapp]-generated-from-SDK Generation - Java-5555237 #47222
Conversation
…pp/NetApp/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '303503695c531db175f23f8e09da2193eff8f701' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5555237 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
|
||
| #### `models.CapacityPoolList` was removed | ||
|
|
||
| #### `models.SubscriptionQuotaItem` was removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Main break is this, renamed to QuotaItem. Let us know if service want to accept it and potentially break user.
Other breaks listed here are expected
##Listis not used by user and hence does not need to be visible- Output-only model does not need to have setter methods
- A few break on
RelationshipStatusis already discussed in TypeSpec PR and is expected - 1 Float -> Integer is also discussed
- A few Float -> Double, if service wish, we can add an emitter option to avoid these
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add @clientame decorator to avoid breaking?
@clientName("NetAppSubscriptionQuotaItem", "csharp")
@clientName("SubscriptionQuotaItem", "java")
@parentResource(SubscriptionLocationResource)
model QuotaItem is Azure.ResourceManager.Pro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can rename in client.tsp. I will add it, and refresh this PR.
(but the question is then why we renamed this to QuotaItem in Swagger, while we still need SubscriptionQuotaItem in SDK...)
…pp/NetApp/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '756699c964e06e55640096504c33ee4828d027fb' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5561685 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
Configurations: 'specification/netapp/resource-manager/Microsoft.NetApp/NetApp/tspconfig.yaml', API Version: 2025-09-01, SDK Release Type: stable, and CommitSHA: '303503695c531db175f23f8e09da2193eff8f701' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5555237 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://web.powerapps.com/apps/821ab569-ae60-420d-8264-d7b5d5ef734c?release-plan-id=10303b69-cead-f011-bbd3-6045bd0569b8 Submitted by: [email protected]
Release Plan Details
Spec pull request: [NetAppFiles] Update to 2025-09-01 azure-rest-api-specs#38406
Spec API version: 2025-09-01