Skip to content

Commit fa9d4d9

Browse files
authored
Update Codeowners rule (#36361)
Remove API review rule from the Codeowners file to unblock service team. Copying's Maor's text before resolving conversation to merge the PR: > Context: > > - GA package shipping is blocked pending APIView approval > - As of 2024, _all_ CODEOWNERS (per group) must sign off on a PR to allow merging > - Prior to that, _any_ CODEOWNER group can sign off on a PR > - While it is helpful for me to review api.md files in smaller diffs (give a developer 10 lines to review and they'll find 10 problems, give them 100 lines and they'll say "looks good" 😄 ) , I think with APIView Copilot improvements and standardization of our client libraries using codegen we can probably view the APIView changes > - Speaking of standardization, we're moving more and more towards codegen first with minimal hand-authored changes, so that's probably another reason to relax this restriction > - When a package is first prepped for release we still need to approve the name which acts as a forcing function to giving the public API a review as well >
1 parent 4219296 commit fa9d4d9

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

.github/CODEOWNERS

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -331,19 +331,10 @@
331331
# ServiceLabel: %Azure Load Testing
332332
/sdk/loadtesting/ @azure/testing-services
333333

334-
# API review files
335-
/sdk/**/review/*api.md @bterlson @Azure/azure-sdk-for-js-core
336-
337-
# Cosmos API review files
338-
/sdk/cosmosdb/cosmos/review/*api.md @amanrao23 @aditishree1 @sajeetharan @topshot99
339-
340334
####################
341335
# Management Libraries
342336
####################
343337

344-
# Managment API review files
345-
/sdk/**/review/arm-*.api.md @qiaozha @MaryGao @Azure/azure-sdk-for-js-core
346-
347338
# PRLabel: %Mgmt
348339
/sdk/advisor/arm-advisor/ @qiaozha @MaryGao
349340

0 commit comments

Comments
 (0)