[engsys] upgrade vitest dev dependencies to v4 #36373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace @vitest/browser with @vitest/browser-playwright
we only ever import and use them as types.
…onfig.json - dev-tool: apply strip-json-comments to tsconfig file contents before parsing. Usually tsconfig.json files allow comments.
because today
- Some of our packages have mix NodeJS/browser usage in same file
- TypeScript `NodeNext` module resolution uses ESM version of built .d.ts files
which may contain pattern of `import { ... } from "node:xxx";`
- Our build-test doesn't do platform file substitution yet so ESM version of
files are included in the build.
Vitest v3 pulls in NodeJS types implicitly but it is no longer the case in
vitest v4.
jeremymeng
requested review from
a team,
JacksonWeber,
Karlie-777,
MSNev,
MaryGao,
benbp,
deyaaeldeen,
hectorhdzg,
maorleger,
mikeharder,
qiaozha,
rads-1996,
timovv and
weshaggard
as code owners
deyaaeldeen
reviewed
Oct 28, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
jeremymeng
requested review from
cRui861,
dpwatrous,
skapur12 and
wanghoppe
as code owners
…ng for fire-and-forget initialization
deyaaeldeen
approved these changes
Nov 5, 2025
Member
Author
|
/check-enforcer override |
github-project-automation
bot
moved this from Untriaged
to Done
in Azure Identity SDK Improvements
github-project-automation
bot
moved this from Untriaged
to Done
in Azure SDK for Key Vault
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bump version to v4 and add @vitest/browser-playwright to dev deps per reference: https://github.com/vitest-dev/vitest/blob/main/docs/guide/migration.md
root tsconfig.browser.config.json workaround: need NodeJS types for browser typechecking because today
NodeNextmodule resolution uses ESM flavor of our built .d.ts files which may contain pattern ofimport { ... } from "node:xxx";vitest v3 pulls in NodeJS types implicitly so it works now but it is no longer the same in vitest v4.
test-utils: remove unused multi version testing support