Refactor: Move MethodProvider building logic to resource provider classes

- Added BuildFactoryMethodProvider() to ResourceClientProvider for singleton resources
- Added BuildMockableGetMethodProvider() to ResourceCollectionClientProvider for collection resources
- Removed BuildGetMethod() static method from MockableResourceProvider
- MockableResourceProvider now delegates MethodProvider building to the resource providers
- This centralizes the XmlDocs copying logic where the signature is built

Co-authored-by: live1206 <[email protected]>

Author: Copilot

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/MockableResourceProvider.cs

@@ -227,25 +227,14 @@ private IEnumerable<MethodProvider> BuildMethodsForResource(ResourceClientProvid
         {
             if (resource.IsSingleton)
             {
-                var resourceMethodSignature = resource.FactoryMethodSignature;
                 var bodyStatement = Return(
                     New.Instance(
                         resource.Type,
                         This.As<ArmResource>().Client(),
                         BuildSingletonResourceIdentifier(This.As<ArmResource>().Id(), resource.ResourceTypeValue, resource.SingletonResourceName!)));
-                var method = new MethodProvider(
-                    resourceMethodSignature,
-                    bodyStatement,
-                    this);
-
-                // Copy the enhanced XML documentation from the singleton resource's Get method if available
-                var enhancedXmlDocs = resource.GetEnhancedFactoryMethodXmlDocs();
-                if (enhancedXmlDocs != null)
-                {
-                    method.XmlDocs?.Update(summary: enhancedXmlDocs);
-                }
 
-                yield return method;
+                // Use the resource provider's method to build the factory method with enhanced XmlDocs
+                yield return resource.BuildFactoryMethodProvider(this, bodyStatement);
             }
             else
             {
@@ -267,40 +256,13 @@ private IEnumerable<MethodProvider> BuildMethodsForResource(ResourceClientProvid
                 if (getAsyncMethod is not null)
                 {
                     // we should be sure that this would never be null, but this null check here is just ensuring that we never crash
-                    yield return BuildGetMethod(this, getAsyncMethod, collectionMethodSignature, pathParameters, $"Get{resource.ResourceName}Async", collection);
+                    yield return collection.BuildMockableGetMethodProvider(this, getAsyncMethod, collectionMethodSignature, pathParameters, $"Get{resource.ResourceName}Async");
                 }
 
                 if (getMethod is not null)
                 {
                     // we should be sure that this would never be null, but this null check here is just ensuring that we never crash
-                    yield return BuildGetMethod(this, getMethod, collectionMethodSignature, pathParameters, $"Get{resource.ResourceName}", collection);
-                }
-
-                static MethodProvider BuildGetMethod(TypeProvider enclosingType, MethodProvider resourceGetMethod, MethodSignature collectionGetSignature, IReadOnlyList<ParameterProvider> pathParameters, string methodName, ResourceCollectionClientProvider collection)
-                {
-                    var signature = new MethodSignature(
-                        methodName,
-                        resourceGetMethod.Signature.Description,
-                        resourceGetMethod.Signature.Modifiers,
-                        resourceGetMethod.Signature.ReturnType,
-                        resourceGetMethod.Signature.ReturnDescription,
-                        [.. pathParameters, .. resourceGetMethod.Signature.Parameters],
-                        Attributes: [new AttributeStatement(typeof(ForwardsClientCallsAttribute))]);
-
-                    var method = new MethodProvider(
-                        signature,
-                        // invoke on a MethodSignature would handle the async extra calls and keyword automatically
-                        Return(This.Invoke(collectionGetSignature).Invoke(resourceGetMethod.Signature)),
-                        enclosingType);
-
-                    // Copy the enhanced XML documentation from the collection's Get method
-                    var enhancedXmlDocs = collection.GetEnhancedGetMethodXmlDocs();
-                    if (enhancedXmlDocs != null)
-                    {
-                        method.XmlDocs?.Update(summary: enhancedXmlDocs);
-                    }
-
-                    return method;
+                    yield return collection.BuildMockableGetMethodProvider(this, getMethod, collectionMethodSignature, pathParameters, $"Get{resource.ResourceName}");
                 }
             }
         }

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/ResourceClientProvider.cs

@@ -181,7 +181,32 @@ private MethodSignature BuildFactoryMethodSignature()
         }
 
         /// <summary>
-        /// Gets the enhanced factory method signature with XML documentation from the resource's Get method.
+        /// Builds a factory method provider for use in mockable resource extensions.
+        /// For singleton resources, this includes enhanced XML documentation from the Get method.
+        /// </summary>
+        /// <param name="enclosingType">The enclosing type (mockable resource) for the method</param>
+        /// <param name="bodyStatement">The method body statement</param>
+        /// <returns>A MethodProvider with the factory signature and enhanced XmlDocs if applicable</returns>
+        internal MethodProvider BuildFactoryMethodProvider(TypeProvider enclosingType, MethodBodyStatement bodyStatement)
+        {
+            var signature = FactoryMethodSignature;
+            var method = new MethodProvider(signature, bodyStatement, enclosingType);
+
+            // For singleton resources, copy enhanced XML documentation from the Get method
+            if (IsSingleton)
+            {
+                var getMethod = Methods.FirstOrDefault(m => m.Signature.Name == "Get");
+                if (getMethod?.XmlDocs?.Summary != null)
+                {
+                    method.XmlDocs?.Update(summary: getMethod.XmlDocs.Summary);
+                }
+            }
+
+            return method;
+        }
+
+        /// <summary>
+        /// Gets the enhanced XML documentation summary from the resource's Get method for singleton resources.
         /// This should be called after Methods are built to get the enhanced documentation.
         /// </summary>
         internal XmlDocSummaryStatement? GetEnhancedFactoryMethodXmlDocs()

eng/packages/http-client-csharp-mgmt/generator/Azure.Generator.Management/src/Providers/ResourceCollectionClientProvider.cs

@@ -443,5 +443,45 @@ public bool TryGetPrivateFieldParameter(ParameterProvider parameter, out FieldPr
             var getMethod = Methods.FirstOrDefault(m => m.Signature.Name == "Get");
             return getMethod?.XmlDocs?.Summary;
         }
+
+        /// <summary>
+        /// Builds a Get method provider for use in mockable resource extensions with enhanced XML documentation.
+        /// </summary>
+        /// <param name="enclosingType">The enclosing type (mockable resource) for the method</param>
+        /// <param name="resourceGetMethod">The source Get method from the collection</param>
+        /// <param name="collectionGetSignature">The signature of the collection getter method</param>
+        /// <param name="pathParameters">Path parameters for the method</param>
+        /// <param name="methodName">The name of the method to build</param>
+        /// <returns>A MethodProvider with enhanced XmlDocs</returns>
+        internal MethodProvider BuildMockableGetMethodProvider(
+            TypeProvider enclosingType,
+            MethodProvider resourceGetMethod,
+            MethodSignature collectionGetSignature,
+            IReadOnlyList<ParameterProvider> pathParameters,
+            string methodName)
+        {
+            var signature = new MethodSignature(
+                methodName,
+                resourceGetMethod.Signature.Description,
+                resourceGetMethod.Signature.Modifiers,
+                resourceGetMethod.Signature.ReturnType,
+                resourceGetMethod.Signature.ReturnDescription,
+                [.. pathParameters, .. resourceGetMethod.Signature.Parameters],
+                Attributes: [new AttributeStatement(typeof(ForwardsClientCallsAttribute))]);
+
+            var method = new MethodProvider(
+                signature,
+                Return(This.Invoke(collectionGetSignature).Invoke(resourceGetMethod.Signature)),
+                enclosingType);
+
+            // Copy the enhanced XML documentation from the collection's Get method
+            var enhancedXmlDocs = GetEnhancedGetMethodXmlDocs();
+            if (enhancedXmlDocs != null)
+            {
+                method.XmlDocs?.Update(summary: enhancedXmlDocs);
+            }
+
+            return method;
+        }
     }
 }