Skip to content

Thread api-version from input JSON to tsp-client emitter options #53750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 7, 2025
Merged

Thread api-version from input JSON to tsp-client emitter options #53750

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a017818
Initial plan
Copilot Nov 7, 2025
fe7c3a9
Add support for passing apiVersion to tsp-client as emitter option
Copilot Nov 7, 2025
efe19e4
Add validation for apiVersion to prevent command injection
Copilot Nov 7, 2025
217ab3a
Fix regex pattern for apiVersion validation
Copilot Nov 7, 2025
ea8c218
Add warning when sdkReleaseType is provided in input JSON
Copilot Nov 7, 2025
f85eac3
Merge remote-tracking branch 'origin/main' into copilot/pass-api-vers…
Copilot Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions eng/scripts/Invoke-GenerateAndBuildV2.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,12 @@ $repoHttpsUrl = $inputJson.repoHttpsUrl
$downloadUrlPrefix = $inputJson.installInstructionInput.downloadUrlPrefix
$autorestConfig = $inputJson.autorestConfig
$relatedTypeSpecProjectFolder = $inputJson.relatedTypeSpecProjectFolder
$apiVersion = $inputJson.apiVersion
$sdkReleaseType = $inputJson.sdkReleaseType

if ($sdkReleaseType) {
Write-Warning "sdkReleaseType is not supported by .NET and user will need to update the package version manually"
}

$autorestConfigYaml = ""
if ($autorestConfig) {
Expand Down Expand Up @@ -150,6 +156,14 @@ if ($relatedTypeSpecProjectFolder) {
if ($swaggerDir) {
$tspclientCommand += " --local-spec-repo $typespecFolder"
}
if ($apiVersion) {
# Validate apiVersion format to prevent command injection - allow alphanumeric, dots, and dashes
if ($apiVersion -match '^[a-zA-Z0-9.-]+$') {
$tspclientCommand += " --emitter-options `"api-version=$apiVersion`""
} else {
Write-Warning "apiVersion '$apiVersion' contains invalid characters and will be skipped. Only alphanumeric characters, dots, and dashes are allowed."
}
}
Write-Host $tspclientCommand
Invoke-Expression $tspclientCommand

Expand Down