BREAKING: disable artifact streaming (#1213)

Co-authored-by: tallaxes <[email protected]>

Author: Bryce-Soghigian

pkg/providers/imagefamily/customscriptsbootstrap/provisionclientbootstrap.go

@@ -107,8 +107,11 @@ func (p *ProvisionClientBootstrap) ConstructProvisionValues(ctx context.Context)
 	labels.AddAgentBakerGeneratedLabels(p.ResourceGroup, options.FromContext(ctx).KubeletIdentityClientID, nodeLabels)
 
 	// artifact streaming is not yet supported for Arm64, for Ubuntu 20.04, Ubuntu 24.04, and for Azure Linux v3
-	enableArtifactStreaming := p.Arch == karpv1.ArchitectureAmd64 &&
-		(p.OSSKU == ImageFamilyOSSKUUbuntu2204 || p.OSSKU == ImageFamilyOSSKUAzureLinux2)
+	// enableArtifactStreaming := p.Arch == karpv1.ArchitectureAmd64 &&
+	//		(p.OSSKU == ImageFamilyOSSKUUbuntu2204 || p.OSSKU == ImageFamilyOSSKUAzureLinux2)
+	// Temporarily disable artifact streaming altogether, until node provisioning performance is fixed
+	// (or until we make artifact streaming configurable)
+	enableArtifactStreaming := false
 
 	// unspecified FIPSMode is effectively no FIPS for now
 	enableFIPS := lo.FromPtr(p.FIPSMode) == v1beta1.FIPSModeFIPS

pkg/providers/imagefamily/customscriptsbootstrap/provisionclientbootstrap_test.go

@@ -333,8 +333,8 @@ func TestConstructProvisionValues(t *testing.T) {
 				// Check system mode
 				assert.Equal(t, models.AgentPoolModeSystem, *profile.Mode)
 
-				// Check artifact streaming is enabled
-				assert.True(t, *profile.ArtifactStreamingProfile.Enabled)
+				// Check artifact streaming is disabled
+				assert.False(t, *profile.ArtifactStreamingProfile.Enabled)
 
 				// Check FIPS enablement (unset/nil FIPSMode is effectively false for now)
 				assert.False(t, *profile.EnableFIPS)
@@ -700,8 +700,8 @@ func TestArtifactStreamingEnablement(t *testing.T) {
 			ossku:                            customscriptsbootstrap.ImageFamilyOSSKUUbuntu2204,
 			kubernetesVersion:                "1.31.0",
 			imageDistro:                      "aks-ubuntu-containerd-22.04-gen2",
-			expectedArtifactStreamingEnabled: true,
-			description:                      "Artifact streaming should be enabled for AMD64 with Ubuntu2204",
+			expectedArtifactStreamingEnabled: false,
+			description:                      "Artifact streaming should be disabled for AMD64 with Ubuntu2204",
 		},
 		{
 			name:                             "AMD64 Ubuntu2404 - Artifact streaming disabled",
@@ -718,8 +718,8 @@ func TestArtifactStreamingEnablement(t *testing.T) {
 			ossku:                            customscriptsbootstrap.ImageFamilyOSSKUAzureLinux2,
 			kubernetesVersion:                "1.31.0",
 			imageDistro:                      "aks-azurelinux-v2-gen2",
-			expectedArtifactStreamingEnabled: true,
-			description:                      "Artifact streaming should be enabled for AMD64 with AzureLinux2",
+			expectedArtifactStreamingEnabled: false,
+			description:                      "Artifact streaming should be disabled for AMD64 with AzureLinux2",
 		},
 		{
 			name:                             "AMD64 AzureLinux3 - Artifact streaming disabled",