Skip to content

feat: Add support for karpenter.azure.com/sku-series label/selector #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Add support for karpenter.azure.com/sku-series label/selector #1234

wants to merge 1 commit into from

Conversation

@hakman
Copy link
Member

@hakman hakman commented Oct 26, 2025 •
edited
Loading

Fixes #

Description

Add support for karpenter.azure.com/sku-series label/selector, equivalent to karpenter.k8s.aws/instance-family:

apiVersion: karpenter.sh/v1beta1
kind: NodePool
metadata:
  name: general-purpose
spec:
  template:
    spec:
      requirements:
        - key: karpenter.azure.com/sku-series
          operator: In
          values: [Ds_v3]

How was this change tested?

Manual testing.

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

Release Note

Adds support for `karpenter.azure.com/sku-series` label/selector

@hakman hakman force-pushed the sku-series branch 2 times, most recently from 8eae42a to db86f32 Compare October 26, 2025 20:20
@hakman
Copy link
Member Author

hakman commented Oct 26, 2025

@microsoft-github-policy-service agree company="Microsoft"

@hakman hakman marked this pull request as draft October 26, 2025 20:41
@hakman hakman force-pushed the sku-series branch 2 times, most recently from 4ca0b32 to 6b73ce9 Compare October 27, 2025 14:04
@hakman hakman marked this pull request as ready for review October 27, 2025 14:27
@wdarko1 wdarko1 requested a review from tallaxes October 27, 2025 14:45
@hakman hakman force-pushed the sku-series branch 4 times, most recently from acbfd32 to 6789314 Compare October 28, 2025 16:04
@hakman
Copy link
Member Author

hakman commented Oct 28, 2025

Test are now passing. Somehow I was missing a CRD update.
Remaining failing tests seem to be flakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tallaxes tallaxes Awaiting requested review from tallaxes

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@hakman