Skip to content

improve doc: use maven central Repo and additional pkg #2383

@childnode

Description

@childnode

fug

is "not working", maven doesn't resolve
https://pkgs.dev.azure.com/MicrosoftDeviceSDK/DuoSDK-Public/_packaging/Duo-SDK-Feed/maven/v1/com/microsoft/identity/client/msal/maven-metadata.xml

nor

any other version from.

https://mvnrepository.com/artifact/com.microsoft.identity.client/msal

only lists maven central too, this should be much more clear on

current documentation https://learn.microsoft.com/en-us/entra/msal/android/ and repo readme which both tell us to add

maven { 
    url 'https://pkgs.dev.azure.com/MicrosoftDeviceSDK/DuoSDK-Public/_packaging/Duo-SDK-Feed/maven/v1' 
}

as documented on other pages, this is needed due to

    //Needed for com.microsoft.device.display:display-mask library

which is indeed a valid case: https://pkgs.dev.azure.com/MicrosoftDeviceSDK/DuoSDK-Public/_packaging/Duo-SDK-Feed/maven/v1/com/microsoft/device/display/display-mask/maven-metadata.xml

But this is not needed for https://learn.microsoft.com/en-us/entra/msal/android/#step-3-configure-the-androidmanifestxml-for-browser-delegated-authentication if you ask me but only for 🦺⁉ PLEASE describe this more clearly

The Dep is included

\--- com.microsoft.identity.client:msal:7.1.0
     +--- com.microsoft.identity:common:22.1.0
     |    …
     |    +--- com.microsoft.device.display:display-mask:0.3.0 FAILED

but not published to mavenCentral..

*RESEARCH relevant Issue: #1027

PLEASE document that not only your repository is needed but mavenCentral too!
Wording like "add" is confusing.. PLEASE Clarify the case of WHEN this is needed, as we can read in the 1.5.0 changelog, it is not relevant at all unless you use a Surface?

It would be MUCH MORE effecient to add it as

repositories {
    maven { 
        url 'https://pkgs.dev.azure.com/MicrosoftDeviceSDK/DuoSDK-Public/_packaging/Duo-SDK-Feed/maven/v1' 
        content {
            includeGroup("com.microsoft.device.display")
        }
    }
}

reproduce

Dysfunctional when only using this repo, bad if added before mavenCentral and google because it causes several network requests,

as you can see when running ./gradlew --refresh-dependencies -i :app:assemble

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions