Remove passing x-client-os as query param in authorization uri (#5456)

Author: neha-bhargava

src/client/Microsoft.Identity.Client/Internal/Requests/Interactive/AuthCodeRequestComponent.cs

@@ -214,10 +214,10 @@ private Dictionary<string, string> CreateAuthorizationRequestParameters(Uri redi
                     _requestParams.RequestContext.CorrelationId.ToString();
             }
 
-            foreach (KeyValuePair<string, string> kvp in MsalIdHelper.GetMsalIdParameters(_requestParams.RequestContext.Logger))
-            {
-                authorizationRequestParameters[kvp.Key] = kvp.Value;
-            }
+            MsalIdHelper.GetMsalIdParameters(_requestParams.RequestContext.Logger)
+                .Where(kvp => kvp.Key != MsalIdParameter.OS)
+                .ToList()
+                .ForEach(kvp => authorizationRequestParameters[kvp.Key] = kvp.Value);
 
             if (_interactiveParameters.Prompt == Prompt.NotSpecified)
             {

tests/Microsoft.Identity.Test.Unit/PublicApiTests/ConfidentialClientApplicationTests.cs

@@ -991,6 +991,8 @@ public async Task GetAuthorizationRequestUrl_IgnoreLoginHint_UseCcsRoutingHint_T
                     .ConfigureAwait(false);
 
                 AssertCcsHint(uri, "oid:oid@tid");
+                Dictionary<string, string> qp = CoreHelpers.ParseKeyValueList(uri.Query.Substring(1), '&', true, null);
+                ValidateCommonQueryParams(qp);
             }
         }
 
@@ -1025,6 +1027,8 @@ public async Task GetAuthorizationRequestUrl_WithLoginHint_UseLoginHintForCcsRou
                     .ConfigureAwait(false);
 
                 AssertCcsHint(uri, $"upn:{TestConstants.DisplayableId}");
+                Dictionary<string, string> qp = CoreHelpers.ParseKeyValueList(uri.Query.Substring(1), '&', true, null);
+                ValidateCommonQueryParams(qp);
             }
         }
 
@@ -1347,7 +1351,7 @@ private static void ValidateCommonQueryParams(
             Assert.AreEqual(Prompt.SelectAccount.PromptValue, qp["prompt"]);
             Assert.AreEqual(TestCommon.CreateDefaultServiceBundle().PlatformProxy.GetProductName(), qp["x-client-sku"]);
             Assert.IsFalse(string.IsNullOrEmpty(qp["x-client-ver"]));
-            Assert.IsFalse(string.IsNullOrEmpty(qp["x-client-os"]));
+            Assert.IsFalse(qp.ContainsKey("x-client-os"));
         }
 
         [TestMethod]