Skipping past stories with undefined url and title #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magebeans
force-pushed
the
skip-undefined-stories
branch
from
4e24b08 to
58ae205
Compare
Author
|
Thanks for the awesome piece of software! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started getting 502s from using this recently, and reading the stack trace found that Pocket was sometimes returning
storyobjects with notitleorresolved_urlfields, just anid. No idea why, but all it takes is one bad story and the whole catalog becomes unusable. Adding this check to skip over problematic stories fixes this.