display receipt: fix isOptOut condition

abarisain · abarisain · commit 477127a45198 · 2020-12-17T11:01:22.000+01:00
the missing key wasn't checked properly, the opt out only worked when it was missing
diff --git a/Sources/Swift/Display Receipt/DisplayReceiptCacheHelper.swift b/Sources/Swift/Display Receipt/DisplayReceiptCacheHelper.swift
@@ -121,7 +121,7 @@ internal struct DisplayReceiptCacheHelper {
 
     func isOptOut() throws -> Bool {
         let defaults = try appInformationProvider.sharedDefaults()
-        if defaults.object(forKey: "batch_shared_optout") != nil {
+        if defaults.object(forKey: "batch_shared_optout") == nil {
             // Key is missing, we don't send display receipt
             return true
         }

Original file line number	Diff line number	Diff line change
`@@ -121,7 +121,7 @@ internal struct DisplayReceiptCacheHelper {`
`121`	`121`
`122`	`122`	`func isOptOut() throws -> Bool {`
`123`	`123`	`let defaults = try appInformationProvider.sharedDefaults()`
`124`		`- if defaults.object(forKey: "batch_shared_optout") != nil {`
	`124`	`+ if defaults.object(forKey: "batch_shared_optout") == nil {`
`125`	`125`	`// Key is missing, we don't send display receipt`
`126`	`126`	`return true`
`127`	`127`	`}`