Merge pull request #13582 from BerriAI/remove-network-response-error

Remove ambiguous network response error

Author: krrishdholakia

ui/litellm-dashboard/src/components/SCIM.tsx

@@ -21,6 +21,7 @@ import {
   PlusCircleOutlined
 } from "@ant-design/icons";
 import { parseErrorMessage } from "./shared/errorUtils";
+import NotificationManager from "./molecules/notifications_manager";
 
 interface SCIMConfigProps {
   accessToken: string | null;
@@ -51,7 +52,7 @@ const SCIMConfig: React.FC<SCIMConfigProps> = ({ accessToken, userID, proxySetti
 
   const handleCreateSCIMToken = async (values: any) => {
     if (!accessToken || !userID) {
-      message.error("You need to be logged in to create a SCIM token");
+      NotificationManager.fromBackend("You need to be logged in to create a SCIM token");
       return;
     }
 
@@ -70,7 +71,7 @@ const SCIMConfig: React.FC<SCIMConfigProps> = ({ accessToken, userID, proxySetti
       message.success("SCIM token created successfully");
     } catch (error: any) {
       console.error("Error creating SCIM token:", error);
-      message.error("Failed to create SCIM token: " + parseErrorMessage(error));
+      NotificationManager.fromBackend("Failed to create SCIM token: " + parseErrorMessage(error));
     } finally {
       setIsCreatingToken(false);
     }

ui/litellm-dashboard/src/components/SSOModals.tsx

@@ -161,7 +161,7 @@ const SSOModals: React.FC<SSOModalsProps> = ({
   // Enhanced form submission handler
   const handleFormSubmit = async (formValues: Record<string, any>) => {
     if (!accessToken) {
-      message.error("No access token available");
+      NotificationManager.fromBackend("No access token available");
       return;
     }
 
@@ -173,14 +173,14 @@ const SSOModals: React.FC<SSOModalsProps> = ({
       handleShowInstructions(formValues);
     } catch (error) {
       console.error("Failed to save SSO settings:", error);
-      message.error("Failed to save SSO settings");
+      NotificationManager.fromBackend("Failed to save SSO settings");
     }
   };
 
   // Handle clearing SSO settings
   const handleClearSSO = async () => {
     if (!accessToken) {
-      message.error("No access token available");
+      NotificationManager.fromBackend("No access token available");
       return;
     }
 
@@ -216,7 +216,7 @@ const SSOModals: React.FC<SSOModalsProps> = ({
       message.success("SSO settings cleared successfully");
     } catch (error) {
       console.error("Failed to clear SSO settings:", error);
-      message.error("Failed to clear SSO settings");
+      NotificationManager.fromBackend("Failed to clear SSO settings");
     }
   };
 

ui/litellm-dashboard/src/components/SSOSettings.tsx

@@ -56,7 +56,7 @@ const SSOSettings: React.FC<SSOSettingsProps> = ({ accessToken, possibleUIRoles,
         }
       } catch (error) {
         console.error("Error fetching SSO settings:", error);
-        message.error("Failed to fetch SSO settings");
+        NotificationManager.fromBackend("Failed to fetch SSO settings");
       } finally {
         setLoading(false);
       }
@@ -81,7 +81,7 @@ const SSOSettings: React.FC<SSOSettingsProps> = ({ accessToken, possibleUIRoles,
       setIsEditing(false);
     } catch (error) {
       console.error("Error updating SSO settings:", error);
-      message.error("Failed to update settings: " + error);
+      NotificationManager.fromBackend("Failed to update settings: " + error);
     } finally {
       setSaving(false);
     }

ui/litellm-dashboard/src/components/TeamSSOSettings.tsx

@@ -4,6 +4,7 @@ import { Typography, Spin, message, Switch, Select, Form } from "antd";
 import { getDefaultTeamSettings, updateDefaultTeamSettings, modelAvailableCall } from "./networking";
 import BudgetDurationDropdown, { getBudgetDurationLabel } from "./common_components/budget_duration_dropdown";
 import { getModelDisplayName } from "./key_team_helpers/fetch_available_models_team_key";
+import NotificationManager from "./molecules/notifications_manager";
 
 interface TeamSSOSettingsProps {
   accessToken: string | null;
@@ -47,7 +48,7 @@ const TeamSSOSettings: React.FC<TeamSSOSettingsProps> = ({ accessToken, userID,
         }
       } catch (error) {
         console.error("Error fetching team SSO settings:", error);
-        message.error("Failed to fetch team settings");
+        NotificationManager.fromBackend("Failed to fetch team settings");
       } finally {
         setLoading(false);
       }
@@ -67,7 +68,7 @@ const TeamSSOSettings: React.FC<TeamSSOSettingsProps> = ({ accessToken, userID,
       message.success("Default team settings updated successfully");
     } catch (error) {
       console.error("Error updating team settings:", error);
-      message.error("Failed to update team settings");
+      NotificationManager.fromBackend("Failed to update team settings");
     } finally {
       setSaving(false);
     }

ui/litellm-dashboard/src/components/UIAccessControlForm.tsx

@@ -2,6 +2,7 @@ import React, { useEffect, useState } from "react";
 import { Form, Button as Button2, Select, message } from "antd";
 import { Text, TextInput } from "@tremor/react";
 import { getSSOSettings, updateSSOSettings } from "./networking";
+import NotificationManager from "./molecules/notifications_manager";
 
 interface UIAccessControlFormProps {
   accessToken: string | null;
@@ -52,7 +53,7 @@ const UIAccessControlForm: React.FC<UIAccessControlFormProps> = ({ accessToken,
 
   const handleUIAccessSubmit = async (formValues: Record<string, any>) => {
     if (!accessToken) {
-      message.error("No access token available");
+      NotificationManager.fromBackend("No access token available");
       return;
     }
 
@@ -71,7 +72,7 @@ const UIAccessControlForm: React.FC<UIAccessControlFormProps> = ({ accessToken,
       onSuccess();
     } catch (error) {
       console.error("Failed to save UI access settings:", error);
-      message.error("Failed to save UI access settings");
+      NotificationManager.fromBackend("Failed to save UI access settings");
     } finally {
       setLoading(false);
     }

ui/litellm-dashboard/src/components/add_fallbacks.tsx

@@ -14,6 +14,7 @@ import {
   message,
 } from "antd";
 import { fetchAvailableModels, ModelGroup } from "./chat_ui/llm_calls/fetch_models";
+import NotificationManager from "./molecules/notifications_manager";
 
 interface AddFallbacksProps {
   models?: string[];
@@ -91,10 +92,10 @@ const AddFallbacks: React.FC<AddFallbacksProps> = ({
         // Update routerSettings state
         setRouterSettings(updatedRouterSettings);
     } catch (error) {
-        message.error("Failed to update router settings: " + error, 20);
+        NotificationManager.fromBackend("Failed to update router settings: " + error);
     }
 
-    message.success("router settings updated successfully");
+    NotificationManager.success("router settings updated successfully");
 
     setIsModalVisible(false);
     form.resetFields();

ui/litellm-dashboard/src/components/add_model/add_auto_router_tab.tsx

@@ -11,6 +11,7 @@ import { all_admin_roles } from "@/utils/roles";
 import { handleAddAutoRouterSubmit } from "./handle_add_auto_router_submit";
 import { fetchAvailableModels, ModelGroup } from "../chat_ui/llm_calls/fetch_models";
 import RouterConfigBuilder from "./router_config_builder";
+import NotificationManager from "../molecules/notifications_manager";
 
 interface AddAutoRouterTabProps {
   form: FormInstance;
@@ -79,12 +80,12 @@ const AddAutoRouterTab: React.FC<AddAutoRouterTabProps> = ({
 
     // Check basic required fields first
     if (!currentFormValues.auto_router_name) {
-      message.error("Please enter an Auto Router Name");
+      NotificationManager.fromBackend("Please enter an Auto Router Name");
       return;
     }
 
     if (!currentFormValues.auto_router_default_model) {
-      message.error("Please select a Default Model");
+      NotificationManager.fromBackend("Please select a Default Model");
       return;
     }
 
@@ -98,7 +99,7 @@ const AddAutoRouterTab: React.FC<AddAutoRouterTabProps> = ({
 
     // Custom validation for router config
     if (!routerConfig || !routerConfig.routes || routerConfig.routes.length === 0) {
-      message.error("Please configure at least one route for the auto router");
+      NotificationManager.fromBackend("Please configure at least one route for the auto router");
       return;
     }
 
@@ -108,7 +109,7 @@ const AddAutoRouterTab: React.FC<AddAutoRouterTabProps> = ({
     );
 
     if (invalidRoutes.length > 0) {
-      message.error("Please ensure all routes have a target model, description, and at least one utterance");
+      NotificationManager.fromBackend("Please ensure all routes have a target model, description, and at least one utterance");
       return;
     }
 
@@ -139,9 +140,9 @@ const AddAutoRouterTab: React.FC<AddAutoRouterTabProps> = ({
             };
             return friendlyNames[fieldName] || fieldName;
           });
-          message.error(`Please fill in the following required fields: ${missingFields.join(', ')}`);
+          NotificationManager.fromBackend(`Please fill in the following required fields: ${missingFields.join(', ')}`);
         } else {
-          message.error("Please fill in all required fields");
+          NotificationManager.fromBackend("Please fill in all required fields");
         }
       });
   };

ui/litellm-dashboard/src/components/add_model/handle_add_auto_router_submit.tsx

@@ -1,5 +1,6 @@
 import { message } from "antd";
 import { modelCreateCall, Model } from "../networking";
+import NotificationManager from "../molecules/notifications_manager";
 
 export const handleAddAutoRouterSubmit = async (
   values: any,
@@ -55,6 +56,6 @@ export const handleAddAutoRouterSubmit = async (
 
   } catch (error) {
     console.error("Failed to add auto router:", error);
-    message.error("Failed to add auto router: " + error, 10);
+    NotificationManager.fromBackend("Failed to add auto router: " + error);
   }
 }; 

ui/litellm-dashboard/src/components/add_model/handle_add_model_submit.tsx

@@ -3,6 +3,7 @@ import { provider_map, Providers } from "../provider_info_helpers";
 import { modelCreateCall, Model, testConnectionRequest } from "../networking";
 import React, { useState } from 'react';
 import ConnectionErrorDisplay from './model_connection_test';
+import NotificationManager from "../molecules/notifications_manager";
 
 export const prepareModelAddRequest = async (
     formValues: Record<string, any>,
@@ -100,9 +101,8 @@ export const prepareModelAddRequest = async (
               try {
                 litellmExtraParams = JSON.parse(value);
               } catch (error) {
-                message.error(
-                  "Failed to parse LiteLLM Extra Params: " + error,
-                  10
+                NotificationManager.fromBackend(
+                  "Failed to parse LiteLLM Extra Params: " + error
                 );
                 throw new Error("Failed to parse litellm_extra_params: " + error);
               }
@@ -117,9 +117,8 @@ export const prepareModelAddRequest = async (
               try {
                 modelInfoParams = JSON.parse(value);
               } catch (error) {
-                message.error(
-                  "Failed to parse LiteLLM Extra Params: " + error,
-                  10
+                NotificationManager.fromBackend(
+                  "Failed to parse LiteLLM Extra Params: " + error
                 );
                 throw new Error("Failed to parse litellm_extra_params: " + error);
               }
@@ -151,7 +150,7 @@ export const prepareModelAddRequest = async (
 
       return deployments;
     } catch (error) {
-      message.error("Failed to create model: " + error, 10);
+      NotificationManager.fromBackend("Failed to create model: " + error);
     }
   };
 
@@ -185,7 +184,7 @@ export const handleAddModelSubmit = async (
       callback && callback();
       form.resetFields();
     } catch (error) {
-      message.error("Failed to add model: " + error, 10);
+      NotificationManager.fromBackend("Failed to add model: " + error);
     }
   };
 

ui/litellm-dashboard/src/components/add_pass_through.tsx

@@ -28,6 +28,7 @@ import { list } from "postcss";
 import KeyValueInput from "./key_value_input";
 import { passThroughItem } from "./pass_through_settings";
 import RoutePreview from "./route_preview";
+import NotificationManager from "./molecules/notifications_manager";
 const { Option } = Select2;
 
 interface AddFallbacksProps {
@@ -87,7 +88,7 @@ const AddPassThroughEndpoint: React.FC<AddFallbacksProps> = ({
       setIncludeSubpath(true);
       setIsModalVisible(false);
     } catch (error) {
-      message.error("Error creating pass-through endpoint: " + error, 20);
+      NotificationManager.fromBackend("Error creating pass-through endpoint: " + error);
     } finally {
       setIsLoading(false);
     }