test: update tests

Author: krrishdholakia

litellm/proxy/proxy_server.py

@@ -2679,12 +2679,14 @@ async def _add_router_settings_from_db_config(
             config_router_settings = config_data.get("router_settings", {})
 
             combined_router_settings = {}
-            if config_router_settings is not None and isinstance(
-                config_router_settings, dict
-            ) and db_router_settings is not None and isinstance(
-                db_router_settings.param_value, dict
+            if (
+                config_router_settings is not None
+                and isinstance(config_router_settings, dict)
+                and db_router_settings is not None
+                and isinstance(db_router_settings.param_value, dict)
             ):
                 from litellm.utils import _update_dictionary
+
                 combined_router_settings = _update_dictionary(
                     config_router_settings, db_router_settings.param_value
                 )
@@ -2697,7 +2699,7 @@ async def _add_router_settings_from_db_config(
             ):
                 combined_router_settings = db_router_settings.param_value
 
-            if combined_router_settings is not None:
+            if combined_router_settings:
                 llm_router.update_settings(**combined_router_settings)
 
     def _add_general_settings_from_db_config(

tests/test_litellm/proxy/test_proxy_server.py

@@ -1722,8 +1722,11 @@ async def test_add_router_settings_from_db_config_merge_logic():
     assert combined_settings["retry_delay"] == 2
 
     # Nested dictionaries should be merged (but this is shallow merge)
-    # The entire nested_config dict gets replaced by DB value
-    expected_nested = {"setting2": "db_value2", "setting3": "db_value3"}
+    expected_nested = {
+        "setting1": "config_value1",
+        "setting2": "db_value2",
+        "setting3": "db_value3",
+    }
     assert combined_settings["nested_config"] == expected_nested