Skip to content

Do not use deprecated NAMEID_EMAIL_ADDRESS as default for SAML2 logout #5907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
+2 −3
Open

Do not use deprecated NAMEID_EMAIL_ADDRESS as default for SAML2 logout #5907

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01563ff
Do not use deprecated NAMEID_EMAIL_ADDRESS as default
jdede Nov 20, 2025
deae0b0
Do not use deprecated SAML:1.1 NameIDFormat as default
jdede Nov 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions app/Access/Saml2Service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ public function logout(User $user): array
[],
$user->email,
$sessionIndex,
true,
Constants::NAMEID_EMAIL_ADDRESS
true
);
$id = $toolKit->getLastRequestID();
} catch (Error $error) {
Expand Down
2 changes: 1 addition & 1 deletion app/Config/saml2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
// Specifies constraints on the name identifier to be used to
// represent the requested subject.
// Take a look on lib/Saml2/Constants.php to see the NameIdFormat supported
'NameIDFormat' => 'urn:oasis:names:tc:SAML:1.1:nameid-format:emailAddress',
'NameIDFormat' => 'urn:oasis:names:tc:SAML:2.0:nameid-format:persistent',

// Usually x509cert and privateKey of the SP are provided by files placed at
// the certs folder. But we can also provide them with the following parameters
Expand Down