tree data REVERT do not allow creating more opaque nodes

Would need many additional restrictions and seems
to be a redundant feature.

Reverts 4426310

Author: michalvasko

src/tree_data.h

@@ -1295,10 +1295,10 @@ LIBYANG_API_DECL LY_ERR lyd_new_ext_inner(const struct lysc_ext_instance *ext, c
                                           default flag is changed, it is returned. If the target node exists and is not
                                           a leaf or generally no change occurs in the @p parent tree, NULL is returned and
                                           no error set. */
-#define LYD_NEW_PATH_OPAQ 0x40       /**< Enables the creation of opaque nodes with some specific rules. If a node in
-                                          the path is not uniquely defined ((leaf-)list without a predicate) or has an
-                                          invalid value (leaf/leaf-list), it is created as opaque. Otherwise a regular
-                                          node is created. */
+#define LYD_NEW_PATH_OPAQ 0x40       /**< Enables the creation of opaque nodes with some specific rules. If the __last node__
+                                          in the path is not uniquely defined ((leaf-)list without a predicate) or has an
+                                          invalid value (leaf/leaf-list), it is created as opaque. Otherwise a regular node
+                                          is created. */
 #define LYD_NEW_PATH_WITH_OPAQ 0x80  /**< Consider opaque nodes normally when searching for existing nodes. */
 #define LYD_NEW_ANY_USE_VALUE 0x100  /**< Whether to use dynamic @p value or make a copy. */
 

src/tree_data_new.c

@@ -1588,7 +1588,7 @@ lyd_new_path_check_find_lypath(struct ly_path *path, const char *str_path, const
             }
         } else if ((schema->nodetype == LYS_LIST) &&
                 (!path[u].predicates || (path[u].predicates[0].type != LY_PATH_PREDTYPE_LIST))) {
-            if (!(options & LYD_NEW_PATH_OPAQ)) {
+            if ((u < LY_ARRAY_COUNT(path) - 1) || !(options & LYD_NEW_PATH_OPAQ)) {
                 LOG_LOCSET(schema, NULL);
                 LOGVAL(schema->module->ctx, LYVE_XPATH, "Predicate missing for %s \"%s\" in path \"%s\".",
                         lys_nodetype2str(schema->nodetype), schema->name, str_path);

tests/utests/data/test_new.c

@@ -319,13 +319,6 @@ test_path(void **state)
 
     lyd_free_tree(root);
 
-    ret = lyd_new_path(NULL, UTEST_LYCTX, "/a:l1/c", NULL, LYD_NEW_PATH_OPAQ, &root);
-    assert_int_equal(ret, LY_SUCCESS);
-    assert_null(root->schema);
-    assert_null(lyd_child(root)->schema);
-
-    lyd_free_tree(root);
-
     /* key-less list */
     ret = lyd_new_path2(NULL, UTEST_LYCTX, "/a:c2/l3/x", "val1", 0, 0, 0, &root, &node);
     assert_int_equal(ret, LY_SUCCESS);