fix diagnostics not getting cleared

Author: CapsAdmin

language_server/editor_helper.lua

@@ -328,7 +328,11 @@ function META:Recompile(path, lol, diagnostics)
 	end
 
 	for name, data in pairs(diagnostics) do
-		if #data > 0 then self:OnDiagnostics(name, data) end
+		if #data > 0 then
+			self:OnDiagnostics(name, data)
+		else
+			self:OnClearDiagnostics(name)
+		end
 	end
 
 	return true
@@ -340,6 +344,8 @@ end
 
 function META:OnDiagnostics(name, data) end
 
+function META:OnClearDiagnostics(name) end
+
 function META:OnResponse(response) end
 
 function META:Initialize()

language_server/lsp.lua

@@ -104,6 +104,18 @@ editor_helper:SetConfigFunction(function(path)
 	end
 end)
 
+function editor_helper:OnClearDiagnostics(path)
+	lsp.Call(
+		{
+			method = "textDocument/publishDiagnostics",
+			params = {
+				uri = to_lsp_path(path),
+				diagnostics = {},
+			},
+		}
+	)
+end
+
 function editor_helper:OnDiagnostics(path, data)
 	local DiagnosticSeverity = {
 		error = 1,

test/tests/editor_helper.lua

@@ -400,4 +400,27 @@ loadstring("local x = 'hello'")
 	end
 end
 
+do
+	-- Test that diagnostics are properly cleared when errors are fixed
+	local helper = EditorHelper.New()
+	helper:Initialize()
+	local diagnostics_calls = {}
+
+	function helper:OnDiagnostics(name, data)
+		table.insert(diagnostics_calls, {
+			name = name,
+			data = data,
+			count = #data,
+		})
+	end
+
+	helper:OpenFile(path, [[locwal]])
+	helper:Recompile(path)
+	assert(#diagnostics_calls > 0)
+	diagnostics_calls = {} -- reset
+	helper:UpdateFile(path, [[local a = 1]])
+	helper:Recompile(path)
+	assert(#diagnostics_calls == 0)
+end
+
 _G.TEST = false