add some call depth and mutation count guards to prevent hanging

Author: CapsAdmin

nattlua/analyzer/base/error_handling.lua

@@ -30,6 +30,15 @@ return function(META)
 
 		return ok, err, ...
 	end
+	
+	function META:AssertWarning(ok, err, ...)
+		if not ok then
+			self:Warning(err)
+			return Any()
+		end
+
+		return ok, err, ...
+	end
 
 	function META:AssertWithNode(node, ok, err, ...)
 		if not ok then

nattlua/analyzer/base/scopes.lua

@@ -137,7 +137,9 @@ return function(META)
 				return self:Error(type_errors.const_assignment(key))
 			end
 
-			if not self:MutateUpvalue(upvalue, val) then upvalue:SetValue(val) end
+			self:MutateUpvalue(upvalue, val)
+			
+			upvalue:SetValue(val)
 
 			return upvalue
 		end

nattlua/analyzer/base/upvalue.lua

@@ -1,5 +1,6 @@
 local class = require("nattlua.other.class")
 local mutation_solver = require("nattlua.analyzer.mutation_solver")
+local type_errors = require("nattlua.types.error_messages")
 local tostring = _G.tostring
 local assert = _G.assert
 local table_insert = _G.table.insert
@@ -51,9 +52,14 @@ do
 	function META:Mutate(val, scope, from_tracking)
 		val:SetUpvalue(self)
 		self.Mutations = self.Mutations or {}
+
+		if self.Mutations[100] then return false, type_errors.too_many_mutations() end
+
 		table_insert(self.Mutations, {scope = scope, value = val, from_tracking = from_tracking})
 
 		if from_tracking then scope:AddTrackedObject(self) end
+
+		return true
 	end
 
 	function META:ClearMutations()

nattlua/analyzer/control_flow.lua

@@ -268,6 +268,13 @@ return function(META)
 				end
 			end
 
+			if #self:GetCallStack() > 100 or debug.getinfo(500, "") then
+				local len = 501
+				while debug.getinfo(len, "") do len = len + 1 end
+				self:Error(type_errors.analyzer_callstack_too_deep(#self:GetCallStack(), len))
+				return Tuple():AddRemainder(Tuple({Any()}):SetRepeat(math.huge))
+			end
+
 			self:PushContextValue(
 				"call_stack",
 				{

nattlua/analyzer/mutation_tracking.lua

@@ -65,7 +65,7 @@ return function(META)
 			end
 		end
 
-		tbl:Mutate(key, val, scope, from_tracking)
+		self:AssertWarning(tbl:Mutate(key, val, scope, from_tracking))
 	end
 
 	function META:GetMutatedUpvalue(upvalue)
@@ -83,7 +83,7 @@ return function(META)
 			end
 		end
 
-		upvalue:Mutate(val, scope, from_tracking)
+		self:AssertWarning(upvalue:Mutate(val, scope, from_tracking))
 	end
 
 	function META:ClearScopedTrackedObjects(scope)

nattlua/types/error_messages.lua

@@ -296,4 +296,13 @@ function type_errors.plain_error(msg--[[#: any]])--[[#: Reason]]
 	return {msg}
 end
 
+do
+	function type_errors.analyzer_callstack_too_deep(len1, len2)
+		return {"call stack is too deep. ", len1, " analyzer call frames and ", len2, " lua call stack frames "}
+	end
+
+	function type_errors.too_many_mutations()
+		return {"too many mutations"}
+	end
+end
 return type_errors

nattlua/types/table.lua

@@ -1065,13 +1065,17 @@ do
 
 	function META:Mutate(key, val, scope, from_tracking)
 		local hash = key:GetHashForMutationTracking()
-
-		if hash == nil then return end
+		if hash == nil then return true end
 
 		initialize_table_mutation_tracker(self, scope, key, hash)
+
+		if #self.mutations[hash] > 100 then return false, type_errors.too_many_mutations() end
+
 		table.insert(self.mutations[hash], {scope = scope, value = val, from_tracking = from_tracking, key = key})
 
 		if from_tracking then scope:AddTrackedObject(self) end
+
+		return true
 	end
 
 	function META:ClearMutations()