18342 FIX apc_symmetra: Always show battery replace state

If no batteries required replacement, the check plugin did not add the string "No battery needs replacing" to the results.
Contrary to the description in the man page.

This is now fixed.

SUP-24584
Change-Id: I6061a3b870a62a4acee0c1d87cb9a92955fc5eb2

Author: crazyscientist

.werks/18342.md

@@ -0,0 +1,17 @@
+[//]: # (werk v2)
+# apc_symmetra: Always show battery replace state
+
+key        | value
+---------- | ---
+date       | 2025-07-22T14:54:26+00:00
+version    | 2.4.0p9
+class      | fix
+edition    | cre
+component  | checks
+level      | 1
+compatible | yes
+
+If no batteries required replacement, the check plugin did not add the string "No battery needs replacing" to the results.
+Contrary to the description in the man page.
+
+This is now fixed.

cmk/base/legacy_checks/apc_symmetra.py

@@ -177,7 +177,7 @@ def check_apc_symmetra(_no_item, params, parsed):  # pylint: disable=too-many-br
         }.get(battery_replace, (3, "Battery needs replacing: unknown"))
         if battery_num_batt_packs and int(battery_num_batt_packs) > 1:
             yield 2, "%i batteries need replacing" % int(battery_num_batt_packs)
-        elif state:
+        else:
             yield state, state_readable
 
     if output_status:

tests/unit/checks/generictests/datasets/apc_symmetra_regression_2.py

@@ -0,0 +1,57 @@
+#!/usr/bin/env python3
+# Copyright (C) 2015 Checkmk GmbH - License: GNU General Public License v2
+# This file is part of Checkmk (https://checkmk.com). It is subject to the terms and
+# conditions defined in the file COPYING, which is part of this source code package.
+
+# fmt: off
+# mypy: disable-error-code=var-annotated
+
+checkname = "apc_symmetra"
+
+info = [
+    [],
+    [
+        [
+            "1",
+            "2",
+            "2",
+            "100",
+            "1",
+            "0",
+            "366000",
+            "2",
+            "06/20/2012",
+            "18",
+            "0",
+            "0001010000000000001000000000000000000000000000000000000000000000",
+        ]
+    ],
+]
+
+discovery = {"": [(None, {})], "elphase": [("Battery", {})], "temp": [("Battery", {})]}
+
+checks = {
+    "": [
+        (
+            None,
+            {"capacity": (95, 80), "calibration_state": 0, "battery_replace_state": 0},
+            [
+                (0, "Battery status: normal", []),
+                (0, "No battery needs replacing", []),
+                (0, "Output status: on line (calibration invalid)", []),
+                (0, "Capacity: 100%", [("capacity", 100, 95, 80, 0, 100)]),
+                (0, "Time remaining: 1 hour 1 minute", [("runtime", 61.0, None, None, None, None)]),
+            ],
+        ),
+    ],
+    "elphase": [
+        (
+            "Battery",
+            {"current": (1, 1)},
+            [(0, "Current: 0.0 A", [("current", 0.0, 1, 1, None, None)])],
+        )
+    ],
+    "temp": [
+        ("Battery", {"levels": (50, 60)}, [(0, "18.0 \xb0C", [("temp", 18.0, 50, 60, None, None)])])
+    ],
+}