[BUG] Warning Preprocessor Directive compatibility issue - solution

[asulwer]

#warning "Compiling poly octave DSP without SIMD optimization" changing this line to #pragma message ("Compiling poly octave DSP without SIMD optimization") makes it compatible with all compilers

[asulwer]

i do not have the correct permissions to create a branch and pull request

[asulwer]

is this repository dead?

[jatinchowdhury18]

Sorry for the slow reply... this repository is still active, I'm just very busy with other projects at the moment.

For making a pull request, please create a fork of this repository and create a pull request from your fork.

Out of curiosity, which compilers were having issues with the #warning directive?

Thanks!

[asulwer]

Visual Studio Code compiler. i am compiling now with a few additions that VSCode needed to recognize the intel cpu i am compiling for.

i am going to start working on the some of the issues you have open.

[jatinchowdhury18]

Visual Studio Code compiler. i am compiling now with a few additions that VSCode needed to recognize the intel cpu i am compiling for.

Hmmm... I din't think VS Code shipped with a C++ compiler? BYOD attempts to support the 3 "main" C++ compilers (gcc, clang, and MSVC), but we mostly test clang since that's the compiler used to create the release builds.

i am going to start working on the some of the issues you have open.

Sounds good! As I mentioned, I'm a bit busy at the moment, but I'll do my best to answer any questions you have in a timely manner.

[asulwer]

sorry, i did not give a detailed enough answer. I also have Visual Studio 2022 Professional which is the c++ compiler VSCode is using. I am using the following VSCode Extension CMake Tools

i had to add to line and line a condition for Visual Studio AMD64 _M_AMD64

the original warning preprocessor directive was also added

i had to #include <limits> in krusher_fallback_impl.h

THEN i was able to compile and start debugging.