Issue #131 #137
Closed
Issue #131 #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r empty responses and refining matching logic for assignment IDs during updates.
…it profile assignment handling and issue #131.
…ria and handle empty responses. Update tests to accommodate changes in assignment ID handling.
…plit profile assignments schema
…n_create_context' and 'read_path_method' attributes, improving resource creation logic to handle assignment retrieval more effectively.
…urce creation logic to conditionally retrieve computed values after creation.
danischm
requested changes
Nov 20, 2025
| no_delete: false | ||
| no_import: true | ||
| no_read: false | ||
| get_in_create_context: true |
Member
There was a problem hiding this comment.
I don't think we need to enhance the generator here, as this should not be a common theme. Due to the non-standard endpoint paths, this resource requires code customizations anyway, therefore I would just insert the extra GET after the POST manually in resource.go.
danischm
requested changes
Nov 20, 2025
CHANGELOG.md
Outdated
| @@ -1,3 +1,7 @@ | |||
| ## 1.8.1 | |||
Member
There was a problem hiding this comment.
Let's add a (unreleased) here to emphasize this is not published yet. Also, whenever you update the changelog, make sure you run the generator again to update the changelog in the documentation as well.
…it profile assignment handling and mark it as unreleased.
…`meraki_appliance_single_vlan` resource. Issue #125
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.