Skip to content

Commit 2a9cd8d

Browse files
authored
[bugfixfix] correct _register function place for mooncacke (vllm-project#3747)
correct _register function place for mooncacke - vLLM version: v0.11.0rc3 - vLLM main: vllm-project/vllm@17c540a Signed-off-by: fems14 <[email protected]>
1 parent 93b52c4 commit 2a9cd8d

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

vllm_ascend/distributed/mooncake/mooncake_engine.py

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -126,16 +126,6 @@ def register_kv_caches(self, kv_caches: dict[str, torch.Tensor]):
126126
region_len = self.num_blocks * self.block_len[0]
127127
self._register(base_addr, region_len)
128128

129-
def _register(self, ptr, length):
130-
logger.debug(
131-
"Registering KV cache: ptr=0x%x, length=%d, num_blocks=%d, "
132-
"block_lens=%s", ptr, length, self.num_blocks, self.block_len)
133-
try:
134-
self.m_store.register_buffer(ptr, length)
135-
except Exception as e:
136-
raise RuntimeError(
137-
f"Mooncake memory registration failed. Error is: {e}")
138-
139129
if self.use_layerwise:
140130
self.get_event = threading.Event()
141131
if self.kv_role in ['kv_producer', 'kv_both']:
@@ -170,6 +160,16 @@ def _register(self, ptr, length):
170160
self.kv_recv_thread.start()
171161
ready_event.wait()
172162

163+
def _register(self, ptr, length):
164+
logger.debug(
165+
"Registering KV cache: ptr=0x%x, length=%d, num_blocks=%d, "
166+
"block_lens=%s", ptr, length, self.num_blocks, self.block_len)
167+
try:
168+
self.m_store.register_buffer(ptr, length)
169+
except Exception as e:
170+
raise RuntimeError(
171+
f"Mooncake memory registration failed. Error is: {e}")
172+
173173
def start_load_kv(self, metadata: MooncakeConnectorMetadata):
174174
self.current_layer = 0
175175
self.layerwise_retrievers = []

0 commit comments

Comments
 (0)