Adjusted threshold values for Gestures & distance math in GestureManager (Closes #816) #818
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are stored with Constants.
…es are stored with Constants. Reverted some changes of 0cdaa9b regarding Prefs for threshold values.
11 tasks
CreativeCodeCat
merged commit 804ccd2
into
CodeWorksCreativeHub:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Summary of Changes
Closes #816
Reasoning for rolling back gesture threshold values from int to float: the new Swipe Gesture math was introduced to be more flexible in terms of device sizes. mlauncher now is supposed to react to inches. Adding pixel-based preferences to the base calculation does not follow through with this approach. Hence, a float-based solution is re-implemented.
Key Changes
Test Information