Fix isShortSwipe not registering and inadequat Min/Max Threshold settings #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es are stored with Constants.
…es are stored with Constants. Reverted some changes of 0cdaa9b regarding Prefs for threshold values.
Changed MinThreshold and MaxThreshold in Constants to be float again (Opinionated) changed default Threshold values
# Conflicts: # app/src/main/java/com/github/droidworksstudio/mlauncher/data/Constants.kt # app/src/main/java/com/github/droidworksstudio/mlauncher/data/Prefs.kt
Signed-off-by: 𝙲𝚛𝚎𝚊𝚝𝚒𝚟𝚎𝙲𝚘𝚍𝚎𝙲𝚊𝚝 <[email protected]>
CreativeCodeCat
merged commit 60a06ce
into
CodeWorksCreativeHub:main
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Summary of Changes
This PR fixes two oversights from refactoring swipe gestures to be based on screen size. Min/Max thresholds have been defined as floats again to work with the float-based SwipeThresholds.
Also the GestureManager math for calculating isShortSwipe has been corrected.
Key Changes
Test Information