fix: issues

Author: RaduCristianPopescu

css/settings.css

@@ -2872,8 +2872,8 @@ button.feedzy-action-button {
 	color: #757575;
 	font-size: 13px;
 }
-
- .fz-schedules-table {
+ 
+.fz-schedules-table {
 	border-collapse: collapse;
 }
 

includes/admin/feedzy-rss-feeds-admin.php

@@ -231,6 +231,7 @@ public function enqueue_styles_admin() {
 						'media_iframe_button' => __( 'Set default image', 'feedzy-rss-feeds' ),
 						'action_btn_text_1'   => __( 'Choose image', 'feedzy-rss-feeds' ),
 						'action_btn_text_2'   => __( 'Replace image', 'feedzy-rss-feeds' ),
+						'delete_btn_label'   => __( 'Delete', 'feedzy-rss-feeds' ),
 					),
 				)
 			);
@@ -2938,7 +2939,7 @@ public function validate_feed() {
 	public function append_custom_cron_schedules( $schedules ) {
 
 		$saved_settings = apply_filters( 'feedzy_get_settings', array() );
-		if ( ! empty( $saved_settings['custom_schedules'] ) || ! is_array( $saved_settings['custom_schedules'] ) ) {
+		if ( ! empty( $saved_settings['custom_schedules'] ) && is_array( $saved_settings['custom_schedules'] ) ) {
 			$custom_schedules = $saved_settings['custom_schedules'];
 
 			foreach ( $custom_schedules as $key => $value ) {

includes/layouts/settings.php

@@ -518,21 +518,28 @@ class="form-control"
 													<label class="form-label" for="fz-schedule-interval">
 														<?php esc_html_e( 'Interval (seconds)', 'feedzy-rss-feeds' ); ?>
 													</label>
-													<input type="number" class="form-control" id="fz-schedule-interval" placeholder="3600" min="0" />
+													<input
+														type="number"
+														class="form-control"
+														id="fz-schedule-interval"
+														placeholder="3600"
+														required
+														min="<?php echo esc_attr( defined( 'WP_CRON_LOCK_TIMEOUT' ) ? WP_CRON_LOCK_TIMEOUT : 60 ); ?>"
+													/>
 												</div>
 
 												<div class="fz-form-group">
 													<label class="form-label" for="fz-schedule-display">
 														<?php esc_html_e( 'Display Name', 'feedzy-rss-feeds' ); ?>
 													</label>
-													<input type="text" class="form-control" id="fz-schedule-display" placeholder="Once Hourly" />
+													<input required type="text" class="form-control" id="fz-schedule-display" placeholder="Once Hourly" />
 												</div>
 
 												<div class="fz-form-group">
 													<label class="form-label" for="fz-schedule-name">
 														<?php esc_html_e( 'Internal Name', 'feedzy-rss-feeds' ); ?>
 													</label>
-													<input type="text" class="form-control" id="fz-schedule-name" placeholder="hourly" />
+													<input required type="text" class="form-control" id="fz-schedule-name" placeholder="hourly" />
 												</div>
 												<div class="fz-form-group">
 													<button class="btn btn-primary" id="fz-add-schedule">

js/feedzy-setting.js

@@ -209,6 +209,12 @@ jQuery(function ($) {
 	$('#fz-add-schedule').on('click', function (e) {
 		e.preventDefault();
 
+		const formElem = document.querySelector('form:has(.fz-form-wrap)');
+		if (formElem && formElem.checkValidity() === false) {
+			formElem.reportValidity();
+			return;
+		}
+
 		const interval = $('#fz-schedule-interval').val();
 		const display = $('#fz-schedule-display').val();
 		const name = $('#fz-schedule-name').val();
@@ -219,26 +225,53 @@ jQuery(function ($) {
 
 		const scheduleTable = $('.fz-schedules-table tbody');
 
-		const newRow = $(`
-			<tr data-schedule="${name}">
-				<td class="fz-schedule-attributes">
-					<strong>${name}</strong>
-				</td>
-				<td class="fz-schedule-attributes">
-					${interval}
-				</td>
-				<td class="fz-schedule-attributes">
-					${display}
-				</td>
-				<td class="fz-schedule-attributes">
-					<button type="button" class="btn btn-outline-primary fz-delete-schedule fz-is-destructive" data-schedule="${name}">
-						Delete
-					</button>
-				</td>
-				<input type="hidden" value="${interval}" name="fz-custom-schedule-interval[${name}][interval]">
-				<input type="hidden" value="${display}" name="fz-custom-schedule-interval[${name}][display]">
-			</tr>
-		`);
+		const newRow = $('<tr>').attr('data-schedule', name);
+
+		const nameCell = $('<td>')
+			.addClass('fz-schedule-attributes')
+			.append($('<strong>').text(name));
+
+		const intervalCell = $('<td>')
+			.addClass('fz-schedule-attributes')
+			.text(interval);
+		const displayCell = $('<td>')
+			.addClass('fz-schedule-attributes')
+			.text(display);
+
+		const deleteButton = $('<button>')
+			.attr({
+				type: 'button',
+				'data-schedule': name,
+			})
+			.addClass(
+				'btn btn-outline-primary fz-delete-schedule fz-is-destructive'
+			)
+			.text(window.feedzy_setting.l10n.delete_btn_label);
+
+		const actionCell = $('<td>')
+			.addClass('fz-schedule-attributes')
+			.append(deleteButton);
+
+		const intervalInput = $('<input>').attr({
+			type: 'hidden',
+			value: interval,
+			name: `fz-custom-schedule-interval[${name}][interval]`,
+		});
+
+		const displayInput = $('<input>').attr({
+			type: 'hidden',
+			value: display,
+			name: `fz-custom-schedule-interval[${name}][display]`,
+		});
+
+		newRow.append(
+			nameCell,
+			intervalCell,
+			displayCell,
+			actionCell,
+			intervalInput,
+			displayInput
+		);
 
 		scheduleTable.append(newRow);