refactor: add more context with sprintf

Soare-Robert-Daniel · Soare-Robert-Daniel · commit ccc53015340d · 2024-11-15T18:18:08.000+02:00
diff --git a/includes/abstract/feedzy-rss-feeds-admin-abstract.php b/includes/abstract/feedzy-rss-feeds-admin-abstract.php
@@ -1594,18 +1594,21 @@ private function get_feed_item_filter( $sc, $sizes, $item, $feed_url, $index, $i
 
 		$date_time = apply_filters( 'feedzy_feed_timestamp', $date_time, $feed_url, $item );
 		if ( $meta_args['date'] && ! empty( $meta_args['date_format'] ) ) {
-			$content_meta_values['date'] = apply_filters( 'feedzy_meta_date', __( 'on', 'feedzy-rss-feeds' ) . ' ' . date_i18n( $meta_args['date_format'], $date_time ) . ' ', $date_time, $feed_url, $item );
+			// translators: %s: the date of the imported content.
+			$content_meta_values['date'] = apply_filters( 'feedzy_meta_date', sprintf( __( 'on %s', 'feedzy-rss-feeds' ), date_i18n( $meta_args['date_format'], $date_time ) ) . ' ', $date_time, $feed_url, $item );
 		}
 
 		if ( $meta_args['time'] && ! empty( $meta_args['time_format'] ) ) {
-			$content_meta_values['time'] = apply_filters( 'feedzy_meta_time', __( 'at', 'feedzy-rss-feeds' ) . ' ' . date_i18n( $meta_args['time_format'], $date_time ) . ' ', $date_time, $feed_url, $item );
+			// translators: %s: the time of the imported content.
+			$content_meta_values['time'] = apply_filters( 'feedzy_meta_time', sprintf( __( 'at %s', 'feedzy-rss-feeds' ), date_i18n( $meta_args['time_format'], $date_time ) ) . ' ', $date_time, $feed_url, $item );
 		}
 
 		// categories.
 		if ( $meta_args['categories'] && has_filter( 'feedzy_retrieve_categories' ) ) {
 			$categories = apply_filters( 'feedzy_retrieve_categories', null, $item );
 			if ( ! empty( $categories ) ) {
-				$content_meta_values['categories'] = apply_filters( 'feedzy_meta_categories', __( 'in', 'feedzy-rss-feeds' ) . ' ' . $categories . ' ', $categories, $feed_url, $item );
+				// translators: %s: the category of the imported content.
+				$content_meta_values['categories'] = apply_filters( 'feedzy_meta_categories', sprintf( __( 'in %s', 'feedzy-rss-feeds' ), $categories ) . ' ', $categories, $feed_url, $item );
 			}
 		}
 
diff --git a/js/FeedzyBlock/Editor.js b/js/FeedzyBlock/Editor.js
@@ -490,9 +490,12 @@ class Editor extends Component {
 
                             let meta_values = new Object();
                             meta_values['author'] = __( 'by', 'feedzy-rss-feeds' ) + ' ' + author;
-                            meta_values['date'] = __( 'on', 'feedzy-rss-feeds' ) + ' ' + unescapeHTML( itemDate );
-                            meta_values['time'] = __( 'at', 'feedzy-rss-feeds' ) + ' ' + unescapeHTML( itemTime );
-                            meta_values['categories'] = __( 'in', 'feedzy-rss-feeds' ) + ' ' + unescapeHTML( categories );
+                            // translators: %s: the date of the imported content.
+                            meta_values['date'] = sprintf( __( 'on %s', 'feedzy-rss-feeds' ), unescapeHTML( itemDate ) );
+                            // translators: %s: the time of the imported content.
+                            meta_values['time'] = sprintf( __( 'at %s', 'feedzy-rss-feeds' ), unescapeHTML( itemTime ) );
+                            // translators: %s: the category of the imported content.
+                            meta_values['categories'] = sprintf( __( 'in %s', 'feedzy-rss-feeds' ), unescapeHTML( categories ) );
 
 							return (
 								<li key={i} style={ { padding: '15px 0 25px' } } className={ `rss_item feedzy-rss-col-${ this.props.attributes.columns }` }>

Original file line number	Diff line number	Diff line change
`@@ -1594,18 +1594,21 @@ private function get_feed_item_filter( $sc, $sizes, $item, $feed_url, $index, $i`
`1594`	`1594`
`1595`	`1595`	`$date_time = apply_filters( 'feedzy_feed_timestamp', $date_time, $feed_url, $item );`
`1596`	`1596`	`if ( $meta_args['date'] && ! empty( $meta_args['date_format'] ) ) {`
`1597`		`- $content_meta_values['date'] = apply_filters( 'feedzy_meta_date', __( 'on', 'feedzy-rss-feeds' ) . ' ' . date_i18n( $meta_args['date_format'], $date_time ) . ' ', $date_time, $feed_url, $item );`
	`1597`	`+ // translators: %s: the date of the imported content.`
	`1598`	`+ $content_meta_values['date'] = apply_filters( 'feedzy_meta_date', sprintf( __( 'on %s', 'feedzy-rss-feeds' ), date_i18n( $meta_args['date_format'], $date_time ) ) . ' ', $date_time, $feed_url, $item );`
`1598`	`1599`	`}`
`1599`	`1600`
`1600`	`1601`	`if ( $meta_args['time'] && ! empty( $meta_args['time_format'] ) ) {`
`1601`		`- $content_meta_values['time'] = apply_filters( 'feedzy_meta_time', __( 'at', 'feedzy-rss-feeds' ) . ' ' . date_i18n( $meta_args['time_format'], $date_time ) . ' ', $date_time, $feed_url, $item );`
	`1602`	`+ // translators: %s: the time of the imported content.`
	`1603`	`+ $content_meta_values['time'] = apply_filters( 'feedzy_meta_time', sprintf( __( 'at %s', 'feedzy-rss-feeds' ), date_i18n( $meta_args['time_format'], $date_time ) ) . ' ', $date_time, $feed_url, $item );`
`1602`	`1604`	`}`
`1603`	`1605`
`1604`	`1606`	`// categories.`
`1605`	`1607`	`if ( $meta_args['categories'] && has_filter( 'feedzy_retrieve_categories' ) ) {`
`1606`	`1608`	`$categories = apply_filters( 'feedzy_retrieve_categories', null, $item );`
`1607`	`1609`	`if ( ! empty( $categories ) ) {`
`1608`		`- $content_meta_values['categories'] = apply_filters( 'feedzy_meta_categories', __( 'in', 'feedzy-rss-feeds' ) . ' ' . $categories . ' ', $categories, $feed_url, $item );`
	`1610`	`+ // translators: %s: the category of the imported content.`
	`1611`	`+ $content_meta_values['categories'] = apply_filters( 'feedzy_meta_categories', sprintf( __( 'in %s', 'feedzy-rss-feeds' ), $categories ) . ' ', $categories, $feed_url, $item );`
`1609`	`1612`	`}`
`1610`	`1613`	`}`
`1611`	`1614`