fix: phpstan errors

Author: HardeepAsrani

inc/core/styles/frontend.php

@@ -1083,7 +1083,7 @@ private function setup_scroll_to_top() {
 	/**
 	 * Get scroll to top CSS variables rules.
 	 *
-	 * @return array
+	 * @return array<string, array<string, mixed>>
 	 */
 	private function get_scroll_to_top_rules() {
 		$rules = [

inc/customizer/options/scroll_to_top.php

@@ -28,6 +28,8 @@ class Scroll_To_Top extends Base_Customizer {
 
 	/**
 	 * Base initialization.
+	 * 
+	 * @return void
 	 */
 	public function init() {
 		parent::init();
@@ -36,6 +38,8 @@ public function init() {
 
 	/**
 	 * Live refresh for scroll to top controls.
+	 * 
+	 * @return void
 	 */
 	public function live_refresh_scripts() {
 		if ( ! is_customize_preview() ) {
@@ -94,9 +98,10 @@ public function add_controls() {
 
 	/**
 	 * Register customizer section for the module
+	 *
+	 * @return void
 	 */
 	private function scroll_to_top_section() {
-
 		$this->add_section(
 			new Section(
 				'neve_scroll_to_top',
@@ -112,9 +117,10 @@ private function scroll_to_top_section() {
 
 	/**
 	 * Register option toggle in customizer
+	 * 
+	 * @return void
 	 */
 	private function scroll_to_top_options() {
-
 		$this->add_control(
 			new Control(
 				'neve_scroll_to_top_status',
@@ -321,9 +327,10 @@ class_exists( 'Neve\Customizer\Controls\React\Range' ) ? 'Neve\Customizer\Contro
 
 	/**
 	 * Add style controls for Scroll to top module.
+	 * 
+	 * @return void
 	 */
 	private function scroll_to_top_style_controls() {
-
 		$this->add_control(
 			new Control(
 				'neve_scroll_to_top_style',
@@ -642,6 +649,8 @@ class_exists( 'Neve\Customizer\Controls\React\Range' ) ? 'Neve\Customizer\Contro
 
 	/**
 	 * Active callback for controls that are available only if scroll to top is an image
+	 * 
+	 * @return bool
 	 */
 	public function is_image_type_control() {
 		if ( ! $this->is_module_enabled() ) {
@@ -653,6 +662,8 @@ public function is_image_type_control() {
 
 	/**
 	 * Active callback for controls that are available only if scroll to top is an icon
+	 *
+	 * @return bool
 	 */
 	public function is_icon_type_control() {
 		if ( ! $this->is_module_enabled() ) {
@@ -696,6 +707,8 @@ public function sanitize_scroll_to_top_side( $value ) {
 
 	/**
 	 * Check if Scroll to Top is enabled.
+	 *
+	 * @return bool
 	 */
 	public static function is_enabled() {
 		// Check old option first for backward compatibility.
@@ -717,6 +730,8 @@ public static function is_enabled() {
 
 	/**
 	 * Active callback for scroll to top controls.
+	 *
+	 * @return bool
 	 */
 	public function is_module_enabled() {
 		return self::is_enabled();

inc/customizer/options/upsells.php

@@ -28,13 +28,6 @@ class Upsells extends Base_Customizer {
 	 */
 	private $upsell_url = '';
 
-	/**
-	 * Scroll to top upsell url
-	 *
-	 * @var string
-	 */
-	private $stt_upsell_url = '';
-
 	/**
 	 * Init function
 	 *
@@ -45,8 +38,7 @@ public function init() {
 			return;
 		}
 
-		$this->stt_upsell_url = esc_url_raw( apply_filters( 'neve_upgrade_link_from_child_theme_filter', $this->get_upgrade_url( 'scrolltotop' ) ) );
-		$this->upsell_url     = esc_url_raw( apply_filters( 'neve_upgrade_link_from_child_theme_filter', $this->get_upgrade_url( 'learnmorebtn' ) ) );
+		$this->upsell_url = esc_url_raw( apply_filters( 'neve_upgrade_link_from_child_theme_filter', $this->get_upgrade_url( 'learnmorebtn' ) ) );
 
 		parent::init();
 

inc/views/scroll_to_top.php

@@ -27,14 +27,16 @@ public function init() {
 
 	/**
 	 * Scroll to top amp observer.
+	 * 
+	 * @return void
 	 */
 	public function scroll_to_top_amp() {
 		if ( ! Scroll_To_Top_Options::is_enabled() ) {
-			return false;
+			return;
 		}
 
 		if ( ! neve_is_amp() ) {
-			return false;
+			return;
 		}
 
 		echo '<amp-position-observer on="enter:hideAnim.start; exit:showAnim.start" layout="nodisplay"></amp-position-observer>';
@@ -81,11 +83,12 @@ public function scroll_to_top_amp() {
 		    </script>
 		  </amp-animation>
 		';
-		return true;
 	}
 
 	/**
 	 * Enqueue module scripts
+	 *
+	 * @return void
 	 */
 	public function enqueue_scripts() {
 		if ( ! Scroll_To_Top_Options::is_enabled() ) {
@@ -114,7 +117,7 @@ public function enqueue_scripts() {
 	/**
 	 * Send offset to the JS object
 	 *
-	 * @return array
+	 * @return array<string, mixed>
 	 */
 	private function localize_scroll() {
 		return array(
@@ -124,10 +127,12 @@ private function localize_scroll() {
 
 	/**
 	 * Display scroll to top button
+	 * 
+	 * @return void
 	 */
 	public function render_button() {
 		if ( ! Scroll_To_Top_Options::is_enabled() ) {
-			return false;
+			return;
 		}
 
 		$position       = get_theme_mod( 'neve_scroll_to_top_side', 'right' );
@@ -161,8 +166,6 @@ public function render_button() {
 		}
 
 		echo '</button>';
-
-		return true;
 	}
 
 	/**