-
Notifications
You must be signed in to change notification settings - Fork 86
feat: move scroll to top to free version #4445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@HardeepAsrani, the scroll to top icons are not appearing according to the selection. Here is a video: https://vertis.d.pr/v/cFe9fY |
|
@poonam279 I've fixed that. |
🌍 i18n String Review Report📊 Summary
➕ Added Strings (4) - Click to expand
|
|
I think here we can modify some strings as well to re-use existing. Scroll to Top Icon -> Icon I don't see where we show the "Show button when page is scrolled x pixels." ? |
|
🎉 This PR is included in version 4.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
It's part of this PR: https://github.com/Codeinwp/neve-pro-addon/pull/3101
This PR moves Move to Scroll from Pro version to Free version. Few notes:
[PS; e2e were failing due to browesrs not being able to get downloaded, will trigger later]
Will affect visual aspect of the product
YES
Screenshots
Test instructions
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/neve-pro-addon/issues/3083.