Skip to content

Conversation

@HardeepAsrani
Copy link
Member

@HardeepAsrani HardeepAsrani commented Oct 29, 2025

Summary

It's part of this PR: https://github.com/Codeinwp/neve-pro-addon/pull/3101

This PR moves Move to Scroll from Pro version to Free version. Few notes:

  • It introduces new strings.
  • It adds a migration for from the option to theme mod for enable/disable.

[PS; e2e were failing due to browesrs not being able to get downloaded, will trigger later]

Will affect visual aspect of the product

YES

Screenshots

Test instructions

  • Test to make sure everything works properly, even in previously created websites.
  • Test to make sure there are no errors or issues if this PR is used with an older version of Pro or if it the connected Pro version is used with an older version of Free.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/neve-pro-addon/issues/3083.

@HardeepAsrani HardeepAsrani added the pr-checklist-skip Allow this Pull Request to skip checklist. label Oct 29, 2025
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Oct 29, 2025
@pirate-bot
Copy link
Collaborator

pirate-bot commented Oct 29, 2025

Plugin build for ccc8053 is ready 🛎️!

@HardeepAsrani HardeepAsrani changed the title Feat/issue 3083 feat: move scroll to top to free version Oct 29, 2025
@HardeepAsrani HardeepAsrani requested a review from abaicus October 29, 2025 19:39
@poonam279
Copy link

poonam279 commented Nov 6, 2025

@HardeepAsrani, the scroll to top icons are not appearing according to the selection. Here is a video: https://vertis.d.pr/v/cFe9fY

@HardeepAsrani
Copy link
Member Author

@poonam279 I've fixed that.

@pirate-bot
Copy link
Collaborator

pirate-bot commented Nov 10, 2025

🌍 i18n String Review Report

📊 Summary

Category Count
➕ Added 4
➖ Removed 0
🔄 Changed 0
Total 4
➕ Added Strings (4) - Click to expand
String Location Words Suggested Match
Enable neve/inc/customizer/options... 1 Enable White Label
Offset (px) neve/inc/customizer/options... 2 Offset X
Background Hover Color neve/inc/customizer/options... 3 Background Color
Choose Side neve/inc/customizer/options... 2 No close match
Total 8

@vytisbulkevicius
Copy link
Contributor

@HardeepAsrani,

I think here we can modify some strings as well to re-use existing.

Scroll to Top Icon -> Icon
Enable Scroll to Top -> Enable
Colors -> Color
Scroll to Top -> Scroll To Top

I don't see where we show the "Show button when page is scrolled x pixels." ?

@Codeinwp Codeinwp deleted a comment from pirate-bot Nov 11, 2025
@HardeepAsrani HardeepAsrani merged commit 61eb945 into development Nov 21, 2025
12 of 13 checks passed
@HardeepAsrani HardeepAsrani deleted the feat/issue-3083 branch November 21, 2025 17:00
@pirate-bot
Copy link
Collaborator

🎉 This PR is included in version 4.2.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-checklist-complete The Pull Request checklist is complete. (automatic label) pr-checklist-skip Allow this Pull Request to skip checklist. released Indicate that an issue has been resolved and released in a particular version of the product.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants