Merge pull request #5573 from ikbuibui/fixes/pmacc_dead_code

Small pmacc fixes

Author: PrometheusPi

include/pmacc/particles/memory/boxes/ParticlesBox.hpp

@@ -36,6 +36,8 @@
 
 #include <pmacc/verify.hpp>
 
+#include <new>
+
 namespace pmacc
 {
     /**
@@ -103,7 +105,7 @@ namespace pmacc
 #if (BOOST_LANG_CUDA || BOOST_COMP_HIP)
                 tmp = (FrameType*) m_deviceHeapHandle.malloc(worker.getAcc(), sizeof(FrameType));
 #else
-                tmp = new FrameType;
+                tmp = new(std::nothrow) FrameType;
 #endif
                 if(tmp != nullptr)
                 {

include/pmacc/particles/memory/dataTypes/SuperCell.hpp

@@ -67,17 +67,8 @@ namespace pmacc
             mustShiftVal = value;
         }
 
-        // clang-format tries to reformat this and looses the #if while the #endif persists
-        // clang-format off
         //! get number of particle in the last frame
         HDINLINE uint32_t getSizeLastFrame() const
-#if(ALPAKA_ACC_GPU_HIP_ENABLED && (HIP_VERSION_MAJOR * 100 + HIP_VERSION_MINOR) == 502)
-            /* ROCm 5.2.0 producing particle loss in KernelShiftParticles if this method is defined as `const`.
-             * see: https://github.com/ComputationalRadiationPhysics/picongpu/issues/4305
-             */
-            volatile
-#endif
-        // clang-format on
         {
             constexpr uint32_t frameSize = T_FrameType::frameSize;
 
@@ -95,16 +86,7 @@ namespace pmacc
             return numParticles ? ((numParticles - 1u) % frameSize + 1u) : 0u;
         }
 
-        // clang-format tries to reformat this and looses the #if while the #endif persists
-        // clang-format off
         HDINLINE uint32_t getNumParticles() const
-#if(ALPAKA_ACC_GPU_HIP_ENABLED && (HIP_VERSION_MAJOR * 100 + HIP_VERSION_MINOR) == 502)
-            /* ROCm 5.2.0 producing particle loss in KernelShiftParticles if this method is defined as `const`.
-             * see: https://github.com/ComputationalRadiationPhysics/picongpu/issues/4305
-             */
-            volatile
-#endif
-        // clang-format on
         {
             return numParticles;
         }