Modernize C/C++ code #3210
Open
Modernize C/C++ code #3210
+432
−713
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
reviewed
Nov 23, 2025
Member
vmcj
left a comment
vmcj
left a comment
There was a problem hiding this comment.
Are those the last .c files? If so we can also remove the requirement for gcc as output_validators are c++/python3 only in the spec I think.
meisterT
force-pushed
the
liberror_cppify
branch
from
65d8131 to
a8ce990
Compare
Member
Author
|
I think so, I will wait for CI to finish with the current state and then remove the gcc requirements |
Member
Author
|
Ah, we still have |
eldering
reviewed
Nov 27, 2025
meisterT
force-pushed
the
liberror_cppify
branch
from
a8ce990 to
7341a53
Compare
eldering
reviewed
Nov 28, 2025
meisterT
force-pushed
the
liberror_cppify
branch
from
245ac27 to
58ea7c7
Compare
eldering
approved these changes
Nov 28, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
eldering
approved these changes
Nov 29, 2025
meisterT
force-pushed
the
liberror_cppify
branch
from
58ea7c7 to
968cfce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.