-
Notifications
You must be signed in to change notification settings - Fork 278
Symfony 7.4 upgrade #3240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
nickygerritsen
wants to merge
11
commits into
DOMjudge:main
Choose a base branch
from
nickygerritsen:symfony-7.4
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Symfony 7.4 upgrade #3240
+4,313
−2,205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7d8e05c to
9ebfa38
Compare
9ebfa38 to
8479fcd
Compare
…ible with symfony/cache anymore Since we don't use or need Redis, this is fine
88a0b97 to
eb874e1
Compare
d15278a to
743a4a0
Compare
9ec2280 to
3cbf43e
Compare
vmcj
reviewed
Nov 28, 2025
.github/jobs/composer_setup.sh
Outdated
| PHPVERSION=$(php -r 'echo PHP_MAJOR_VERSION.".".PHP_MINOR_VERSION."\n";') | ||
| export PHPVERSION | ||
| echo "$PHPVERSION" | tee -a "$ARTIFACTS"/phpversion.txt | ||
| sudo apt-get -y remove "php$PHPVERSION-redis" |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably purge it in this case?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.