Skip to content

Commit d20c997

Browse files
authored
v.1.2.1 proposal (#53)
* Fix verbosity level precedence. (#51) * Update version to 1.2.1
1 parent fa360d1 commit d20c997

File tree

5 files changed

+14
-4
lines changed

5 files changed

+14
-4
lines changed

package-lock.json

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "@datadog/native-iast-taint-tracking",
33
"home": "https://github.com/DataDog/dd-native-iast-taint-tracking-js/blob/main/README.md",
44
"repository": "[email protected]:DataDog/dd-native-iast-taint-tracking-js.git",
5-
"version": "1.2.0",
5+
"version": "1.2.1",
66
"description": "Datadog IAST tant tracking support for NodeJS",
77
"main": "index.js",
88
"scripts": {

src/api/metrics.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ void GetMetrics(const FunctionCallbackInfo<Value>& args) {
5151
auto context = isolate->GetCurrentContext();
5252
auto jsMetrics = Object::New(isolate);
5353
switch (static_cast<TelemetryVerbosity>(telemetryVerbosity->IntegerValue(context).FromJust())) {
54+
case TelemetryVerbosity::DEBUG:
5455
case TelemetryVerbosity::INFORMATION:
5556
jsMetrics->Set(context,
5657
utils::NewV8String(isolate, "requestCount"),

src/api/string_methods.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ using v8::Object;
3131
using v8::String;
3232
using v8::Value;
3333
using v8::Array;
34-
using v8::Number;
3534

3635
using iast::tainted::InputInfo;
3736

test/js/metrics.spec.js

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -46,4 +46,14 @@ describe('Metrics', function () {
4646
expected.requestCount = 2
4747
assert.deepEqual(expected, TaintedUtils.getMetrics(id, Verbosity.INFORMATION), 'Metrics expected to be equal')
4848
})
49+
50+
it('Should return the properties in all verbosity levels', function () {
51+
const expected = {
52+
requestCount: 1
53+
}
54+
55+
TaintedUtils.newTaintedString(id, 'a', 'param', 'request')
56+
assert.deepEqual(expected, TaintedUtils.getMetrics(id, Verbosity.INFORMATION), 'Metrics expected to be equal')
57+
assert.deepEqual(expected, TaintedUtils.getMetrics(id, Verbosity.DEBUG), 'Metrics expected to be equal')
58+
})
4959
})

0 commit comments

Comments
 (0)