Skip to content

Commit 1d94c9f

Browse files
Chore: Add counterpart for constants for tests
1 parent e54f31b commit 1d94c9f

File tree

1 file changed

+16
-6
lines changed

1 file changed

+16
-6
lines changed

DatadogRUM/Tests/Instrumentation/Resources/URLSessionRUMResourcesHandlerTests.swift

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -954,10 +954,10 @@ class URLSessionRUMResourcesHandlerTests: XCTestCase {
954954

955955
// Given
956956
var mockRequest: URLRequest = .mockWith(url: "https://graphql.example.com/api")
957-
mockRequest.setValue("GetUser", forHTTPHeaderField: GraphQLHeaders.operationName)
958-
mockRequest.setValue("query", forHTTPHeaderField: GraphQLHeaders.operationType)
959-
mockRequest.setValue("{\"userId\":\"123\"}", forHTTPHeaderField: GraphQLHeaders.variables)
960-
mockRequest.setValue("query GetUser($userId: ID!) { user(id: $userId) { name } }", forHTTPHeaderField: GraphQLHeaders.payload)
957+
mockRequest.setValue("GetUser", forHTTPHeaderField: ExpectedGraphQLHeaders.operationName)
958+
mockRequest.setValue("query", forHTTPHeaderField: ExpectedGraphQLHeaders.operationType)
959+
mockRequest.setValue("{\"userId\":\"123\"}", forHTTPHeaderField: ExpectedGraphQLHeaders.variables)
960+
mockRequest.setValue("query GetUser($userId: ID!) { user(id: $userId) { name } }", forHTTPHeaderField: ExpectedGraphQLHeaders.payload)
961961

962962
let immutableRequest = ImmutableRequest(request: mockRequest)
963963
let taskInterception = URLSessionTaskInterception(request: immutableRequest, isFirstParty: false)
@@ -989,8 +989,8 @@ class URLSessionRUMResourcesHandlerTests: XCTestCase {
989989

990990
// Given
991991
var mockRequest: URLRequest = .mockWith(url: "https://graphql.example.com/api")
992-
mockRequest.setValue("FailedMutation", forHTTPHeaderField: GraphQLHeaders.operationName)
993-
mockRequest.setValue("mutation", forHTTPHeaderField: GraphQLHeaders.operationType)
992+
mockRequest.setValue("FailedMutation", forHTTPHeaderField: ExpectedGraphQLHeaders.operationName)
993+
mockRequest.setValue("mutation", forHTTPHeaderField: ExpectedGraphQLHeaders.operationType)
994994

995995
let immutableRequest = ImmutableRequest(request: mockRequest)
996996
let taskInterception = URLSessionTaskInterception(request: immutableRequest, isFirstParty: false)
@@ -1008,6 +1008,7 @@ class URLSessionRUMResourcesHandlerTests: XCTestCase {
10081008
XCTAssertEqual(attributes[CrossPlatformAttributes.graphqlOperationType] as? String, "mutation")
10091009
}
10101010

1011+
10111012
// MARK: - Helper Methods
10121013

10131014
private func extractBaggageKeyValuePairs(from header: String) -> [String: String] {
@@ -1028,3 +1029,12 @@ class URLSessionRUMResourcesHandlerTests: XCTestCase {
10281029
return dict
10291030
}
10301031
}
1032+
1033+
// MARK: - Test Helpers
1034+
1035+
struct ExpectedGraphQLHeaders {
1036+
static let operationName: String = "_dd-custom-header-graph-ql-operation-name"
1037+
static let operationType: String = "_dd-custom-header-graph-ql-operation-type"
1038+
static let variables: String = "_dd-custom-header-graph-ql-variables"
1039+
static let payload: String = "_dd-custom-header-graph-ql-payload"
1040+
}

0 commit comments

Comments
 (0)