Skip to content

Chore: Add counterpart for GraphQL constants for tests #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2025
Merged

Chore: Add counterpart for GraphQL constants for tests #2558

merged 1 commit into from
Oct 31, 2025

Conversation

@barboraplasovska
Copy link
Contributor

What and why?

This PR adds the counterpart for the GraphQL constants for testing to ensure if typo occurs the tests do break.

Review checklist

  • Feature or bugfix MUST have appropriate tests (unit, integration)
  • Make sure each commit and the PR mention the Issue number or JIRA reference
  • Add CHANGELOG entry for user facing changes
  • Add Objective-C interface for public APIs (see our guidelines (internal) and run make api-surface)

@barboraplasovska barboraplasovska self-assigned this Oct 31, 2025
@barboraplasovska barboraplasovska force-pushed the bplasovska/chore/graphql-constants-tests branch from 6c94a5a to 1d94c9f Compare October 31, 2025 10:23
@barboraplasovska barboraplasovska marked this pull request as ready for review October 31, 2025 10:24
@barboraplasovska barboraplasovska requested review from a team as code owners October 31, 2025 10:24
Valpertui
Valpertui previously approved these changes Oct 31, 2025
View reviewed changes
@barboraplasovska
Copy link
Contributor Author

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codex bot commented Oct 31, 2025 •
edited
Loading

View all feedbacks in Devflow UI.

2025-10-31 10:33:59 UTC ℹ️ Start processing command /merge

2025-10-31 10:34:04 UTC ℹ️ MergeQueue: waiting for PR to be ready

This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.

2025-10-31 13:38:09 UTC ℹ️ MergeQueue: merge request added to the queue

The expected merge time in develop is approximately 49m (p90).

2025-10-31 15:13:21 UTC ℹ️ MergeQueue: This merge request was merged

@barboraplasovska barboraplasovska force-pushed the bplasovska/chore/graphql-constants-tests branch from 1d94c9f to 0d2b2db Compare October 31, 2025 12:40
@dd-mergequeue dd-mergequeue bot merged commit d63a4c3 into develop Oct 31, 2025
19 checks passed
@dd-mergequeue dd-mergequeue bot deleted the bplasovska/chore/graphql-constants-tests branch October 31, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Valpertui Valpertui Valpertui approved these changes

Assignees

@barboraplasovska barboraplasovska

Labels

mergequeue-status: done

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@barboraplasovska @Valpertui