Update debugger ExporterSettings - this only uses the initial settings though, and doesn't respond to changes

Author: andrewlock

tracer/src/Datadog.Trace/Debugger/DebuggerFactory.cs

@@ -60,7 +60,7 @@ private static IDogStatsd GetDogStatsd(TracerSettings tracerSettings, string ser
     {
         IDogStatsd statsd;
         if (FrameworkDescription.Instance.IsWindows()
-         && tracerSettings.Exporter.MetricsTransport == TransportType.UDS)
+         && tracerSettings.Manager.InitialExporterSettings.MetricsTransport == TransportType.UDS)
         {
             Log.Information("Metric probes are not supported on Windows when transport type is UDS");
             statsd = NoOpStatsd.Instance;
@@ -70,7 +70,7 @@ private static IDogStatsd GetDogStatsd(TracerSettings tracerSettings, string ser
             // TODO: use StatsdManager to get automatic updating on exporter and other setting changes
             statsd = StatsdFactory.CreateDogStatsdClient(
                 tracerSettings.Manager.InitialMutableSettings,
-                tracerSettings.Exporter,
+                tracerSettings.Manager.InitialExporterSettings,
                 includeDefaultTags: false,
                 prefix: DebuggerSettings.DebuggerMetricPrefix);
         }
@@ -119,7 +119,7 @@ private static IApiRequestFactory GetApiFactory(TracerSettings tracerSettings, b
     {
         // TODO: we need to be able to update the tracer settings dynamically
         return AgentTransportStrategy.Get(
-            tracerSettings.Exporter,
+            tracerSettings.Manager.InitialExporterSettings,
             productName: "debugger",
             tcpTimeout: TimeSpan.FromSeconds(15),
             AgentHttpHeaderNames.MinimalHeaders,

tracer/src/Datadog.Trace/Debugger/ExceptionAutoInstrumentation/ExceptionReplay.cs

@@ -65,8 +65,9 @@ private void InitSnapshotsSink()
             // Set up the snapshots sink.
             var snapshotSlicer = SnapshotSlicer.Create(debuggerSettings);
             _snapshotSink = SnapshotSink.Create(debuggerSettings, snapshotSlicer);
+            // TODO: respond to changes in exporter settings
             var apiFactory = AgentTransportStrategy.Get(
-                tracer.Settings.Exporter,
+                tracer.Settings.Manager.InitialExporterSettings,
                 productName: "debugger",
                 tcpTimeout: TimeSpan.FromSeconds(15),
                 AgentHttpHeaderNames.MinimalHeaders,

tracer/src/Datadog.Trace/TracerManager.cs

@@ -324,6 +324,8 @@ private static async Task WriteDiagnosticLog(TracerManager instance)
                 string agentError = null;
                 var instanceSettings = instance.Settings;
                 var mutableSettings = instance.PerTraceSettings.Settings;
+                // TODO: this only writes the initial settings - we should make sure to record an "update" log on reconfiguration
+                var exporterSettings = instanceSettings.Manager.InitialExporterSettings;
 
                 // In AAS, the trace agent is deployed alongside the tracer and managed by the tracer
                 // Disable this check as it may hit the trace agent before it is ready to receive requests and give false negatives
@@ -401,10 +403,10 @@ void WriteDictionary(IReadOnlyDictionary<string, string> dictionary)
                     writer.WriteValue(mutableSettings.DefaultServiceName);
 
                     writer.WritePropertyName("agent_url");
-                    writer.WriteValue(instanceSettings.Exporter.TraceAgentUriBase);
+                    writer.WriteValue(exporterSettings.TraceAgentUriBase);
 
                     writer.WritePropertyName("agent_transport");
-                    writer.WriteValue(instanceSettings.Exporter.TracesTransport.ToString());
+                    writer.WriteValue(exporterSettings.TracesTransport.ToString());
 
                     writer.WritePropertyName("debug");
                     writer.WriteValue(GlobalSettings.Instance.DebugEnabledInternal);
@@ -518,7 +520,7 @@ void WriteDictionary(IReadOnlyDictionary<string, string> dictionary)
                     writer.WritePropertyName("exporter_settings_warning");
                     writer.WriteStartArray();
 
-                    foreach (var warning in instanceSettings.Exporter.ValidationWarnings)
+                    foreach (var warning in exporterSettings.ValidationWarnings)
                     {
                         writer.WriteValue(warning);
                     }