TracerSettings no longer uses DynamicSettings

Author: andrewlock

tracer/src/Datadog.Trace/Configuration/TracerSettings.cs

@@ -675,7 +675,7 @@ not null when string.Equals(x, "lowmemory", StringComparison.OrdinalIgnoreCase)
         internal bool GitMetadataEnabled { get; }
 
         /// <inheritdoc cref="MutableSettings.TraceEnabled"/>
-        public bool TraceEnabled => DynamicSettings.TraceEnabled ?? MutableSettings.TraceEnabled;
+        public bool TraceEnabled => MutableSettings.TraceEnabled;
 
         /// <summary>
         /// Gets a value indicating whether APM traces are enabled.
@@ -777,15 +777,15 @@ not null when string.Equals(x, "lowmemory", StringComparison.OrdinalIgnoreCase)
         public bool AnalyticsEnabled => MutableSettings.AnalyticsEnabled;
 
         /// <inheritdoc cref="MutableSettings.LogsInjectionEnabled"/>
-        public bool LogsInjectionEnabled => DynamicSettings.LogsInjectionEnabled ?? MutableSettings.LogsInjectionEnabled;
+        public bool LogsInjectionEnabled => MutableSettings.LogsInjectionEnabled;
 
         /// <inheritdoc cref="MutableSettings.MaxTracesSubmittedPerSecond"/>
         public int MaxTracesSubmittedPerSecond => MutableSettings.MaxTracesSubmittedPerSecond;
 
         /// <inheritdoc cref="MutableSettings.CustomSamplingRules"/>
-        public string? CustomSamplingRules => DynamicSettings.SamplingRules ?? MutableSettings.CustomSamplingRules;
+        public string? CustomSamplingRules => MutableSettings.CustomSamplingRules;
 
-        internal bool CustomSamplingRulesIsRemote => DynamicSettings.SamplingRules != null;
+        internal bool CustomSamplingRulesIsRemote => MutableSettings.CustomSamplingRulesIsRemote;
 
         /// <summary>
         /// Gets a value indicating the format for custom trace sampling rules ("regex" or "glob").
@@ -801,16 +801,16 @@ not null when string.Equals(x, "lowmemory", StringComparison.OrdinalIgnoreCase)
         internal string? SpanSamplingRules { get; }
 
         /// <inheritdoc cref="MutableSettings.GlobalSamplingRate"/>
-        public double? GlobalSamplingRate => DynamicSettings.GlobalSamplingRate ?? MutableSettings.GlobalSamplingRate;
+        public double? GlobalSamplingRate => MutableSettings.GlobalSamplingRate;
 
         /// <inheritdoc cref="MutableSettings.Integrations"/>
         public IntegrationSettingsCollection Integrations => MutableSettings.Integrations;
 
         /// <inheritdoc cref="MutableSettings.GlobalTags"/>
-        public IReadOnlyDictionary<string, string> GlobalTags => DynamicSettings.GlobalTags ?? MutableSettings.GlobalTags;
+        public IReadOnlyDictionary<string, string> GlobalTags => MutableSettings.GlobalTags;
 
         /// <inheritdoc cref="MutableSettings.HeaderTags"/>
-        public IReadOnlyDictionary<string, string> HeaderTags => DynamicSettings.HeaderTags ?? MutableSettings.HeaderTags;
+        public IReadOnlyDictionary<string, string> HeaderTags => MutableSettings.HeaderTags;
 
         /// <summary>
         /// Gets a custom request header configured to read the ip from. For backward compatibility, it fallbacks on DD_APPSEC_IPHEADER
@@ -1170,8 +1170,6 @@ public bool DiagnosticSourceEnabled
         /// </summary>
         public int PartialFlushMinSpans { get; }
 
-        internal ImmutableDynamicSettings DynamicSettings { get; init; } = new();
-
         internal List<string> JsonConfigurationFilePaths { get; } = new();
 
         /// <summary>