nit: Extract diagnostics to separate files (needed for subsequent update)

Author: andrewlock

tracer/src/Datadog.Trace.Tools.Analyzers/AspectAnalyzers/BeforeAfterAspectAnalyzer.cs

@@ -21,19 +21,14 @@ namespace Datadog.Trace.Tools.Analyzers.AspectAnalyzers;
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 public class BeforeAfterAspectAnalyzer : DiagnosticAnalyzer
 {
-    /// <summary>
-    /// The diagnostic ID displayed in error messages
-    /// </summary>
-    public const string DiagnosticId = "DD0004";
-
     /// <summary>
     /// The severity of the diagnostic
     /// </summary>
     public const DiagnosticSeverity Severity = DiagnosticSeverity.Error;
 
 #pragma warning disable RS2008 // Enable analyzer release tracking for the analyzer project
     private static readonly DiagnosticDescriptor MissingTryCatchRule = new(
-        DiagnosticId,
+        Diagnostics.BeforeAfterAspectDiagnosticId,
         title: "Aspect is missing try-catch block",
         messageFormat: "Aspect method bodies should contain a try-catch block at the top level",
         category: "Reliability",

tracer/src/Datadog.Trace.Tools.Analyzers/AspectAnalyzers/BeforeAfterAspectCodeFixProvider.cs

@@ -30,7 +30,7 @@ public class BeforeAfterAspectCodeFixProvider : CodeFixProvider
     /// <inheritdoc />
     public sealed override ImmutableArray<string> FixableDiagnosticIds
     {
-        get => ImmutableArray.Create(BeforeAfterAspectAnalyzer.DiagnosticId);
+        get => ImmutableArray.Create(Diagnostics.BeforeAfterAspectDiagnosticId);
     }
 
     /// <inheritdoc />

tracer/src/Datadog.Trace.Tools.Analyzers/AspectAnalyzers/Diagnostics.cs

@@ -0,0 +1,22 @@
+// <copyright file="Diagnostics.cs" company="Datadog">
+// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
+// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+// </copyright>
+
+namespace Datadog.Trace.Tools.Analyzers.AspectAnalyzers;
+
+/// <summary>
+/// Helper class for holding various diagnostics.
+/// </summary>
+public class Diagnostics
+{
+    /// <summary>
+    /// The diagnostic ID displayed in error messages
+    /// </summary>
+    public const string BeforeAfterAspectDiagnosticId = "DD0004";
+
+    /// <summary>
+    /// The diagnostic ID displayed in error messages
+    /// </summary>
+    public const string ReplaceAspectDiagnosticId = "DD0005";
+}

tracer/src/Datadog.Trace.Tools.Analyzers/AspectAnalyzers/ReplaceAspectAnalyzer.cs

@@ -20,19 +20,14 @@ namespace Datadog.Trace.Tools.Analyzers.AspectAnalyzers;
 [DiagnosticAnalyzer(LanguageNames.CSharp)]
 public class ReplaceAspectAnalyzer : DiagnosticAnalyzer
 {
-    /// <summary>
-    /// The diagnostic ID displayed in error messages
-    /// </summary>
-    public const string DiagnosticId = "DD0005";
-
     /// <summary>
     /// The severity of the diagnostic
     /// </summary>
     public const DiagnosticSeverity Severity = DiagnosticSeverity.Error;
 
 #pragma warning disable RS2008 // Enable analyzer release tracking for the analyzer project
     private static readonly DiagnosticDescriptor MissingTryCatchRule = new(
-        DiagnosticId,
+        Diagnostics.ReplaceAspectDiagnosticId,
         title: "Aspect is in incorrect format",
         messageFormat: "Aspect method bodies should contain a single expression to set the result variable, and then have a try-catch block, and then return the created variable",
         category: "Reliability",

tracer/src/Datadog.Trace.Tools.Analyzers/AspectAnalyzers/ReplaceAspectCodeFixProvider.cs

@@ -29,7 +29,7 @@ public class ReplaceAspectCodeFixProvider : CodeFixProvider
     /// <inheritdoc />
     public sealed override ImmutableArray<string> FixableDiagnosticIds
     {
-        get => ImmutableArray.Create(ReplaceAspectAnalyzer.DiagnosticId);
+        get => ImmutableArray.Create(Diagnostics.ReplaceAspectDiagnosticId);
     }
 
     /// <inheritdoc />

tracer/src/Datadog.Trace.Tools.Analyzers/ThreadAbortAnalyzer/Diagnostics.cs

@@ -0,0 +1,17 @@
+// <copyright file="Diagnostics.cs" company="Datadog">
+// Unless explicitly stated otherwise all files in this repository are licensed under the Apache 2 License.
+// This product includes software developed at Datadog (https://www.datadoghq.com/). Copyright 2017 Datadog, Inc.
+// </copyright>
+
+namespace Datadog.Trace.Tools.Analyzers.ThreadAbortAnalyzer;
+
+/// <summary>
+/// Helper class for holding various diagnostics.
+/// </summary>
+public class Diagnostics
+{
+    /// <summary>
+    /// The diagnostic ID displayed in error messages
+    /// </summary>
+    public const string ThreadAbortDiagnosticId = "DD0001";
+}

tracer/src/Datadog.Trace.Tools.Analyzers/ThreadAbortAnalyzer/ThreadAbortAnalyzer.cs

@@ -45,14 +45,9 @@ namespace Datadog.Trace.Tools.Analyzers.ThreadAbortAnalyzer
     [DiagnosticAnalyzer(LanguageNames.CSharp)]
     public class ThreadAbortAnalyzer : DiagnosticAnalyzer
     {
-        /// <summary>
-        /// The diagnostic ID displayed in error messages
-        /// </summary>
-        public const string DiagnosticId = "DD0001";
-
 #pragma warning disable RS2008 // Enable analyzer release tracking for the analyzer project
         private static readonly DiagnosticDescriptor Rule = new DiagnosticDescriptor(
-            DiagnosticId,
+            Diagnostics.ThreadAbortDiagnosticId,
             title: "Potential infinite loop on ThreadAbortException",
             messageFormat: "Potential infinite loop - you should rethrow Exception in catch block",
             category: "Reliability",

tracer/src/Datadog.Trace.Tools.Analyzers/ThreadAbortAnalyzer/ThreadAbortCodeFixProvider.cs

@@ -26,7 +26,7 @@ public class ThreadAbortCodeFixProvider : CodeFixProvider
         /// <inheritdoc />
         public sealed override ImmutableArray<string> FixableDiagnosticIds
         {
-            get { return ImmutableArray.Create(ThreadAbortAnalyzer.DiagnosticId); }
+            get { return ImmutableArray.Create(Diagnostics.ThreadAbortDiagnosticId); }
         }
 
         /// <inheritdoc />

tracer/test/Datadog.Trace.Tools.Analyzers.Tests/AspectAnalyzers/BeforeAfterAspectAnalyzerTests.cs

@@ -17,7 +17,7 @@ namespace Datadog.Trace.Tools.Analyzers.Tests.AspectAnalyzers;
 
 public class BeforeAfterAspectAnalyzerTests
 {
-    private const string DiagnosticId = BeforeAfterAspectAnalyzer.DiagnosticId;
+    private const string DiagnosticId = Diagnostics.BeforeAfterAspectDiagnosticId;
     private const DiagnosticSeverity Severity = BeforeAfterAspectAnalyzer.Severity;
 
     // No diagnostics expected to show up

tracer/test/Datadog.Trace.Tools.Analyzers.Tests/AspectAnalyzers/ReplaceAspectAnalyzerTests.cs

@@ -17,7 +17,7 @@ namespace Datadog.Trace.Tools.Analyzers.Tests.AspectAnalyzers;
 
 public class ReplaceAspectAnalyzerTests
 {
-    private const string DiagnosticId = ReplaceAspectAnalyzer.DiagnosticId;
+    private const string DiagnosticId = Diagnostics.ReplaceAspectDiagnosticId;
     private const DiagnosticSeverity Severity = ReplaceAspectAnalyzer.Severity;
 
     // No diagnostics expected to show up