Skip to content

Commit 85deee3

Browse files
committed
Comments minor changes
1 parent 8776673 commit 85deee3

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

tracer/src/Datadog.Trace.SourceGenerators/Configuration/ConfigurationKeysGenerator.cs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -404,7 +404,9 @@ private static void GenerateConstDeclaration(StringBuilder sb, ConfigEntry entry
404404
var trimmedLine = line.TrimStart();
405405

406406
// Check if line contains seealso tag (self-closing /> or closing </seealso>) as we need to extract it
407-
if (trimmedLine.StartsWith("<seealso") && (trimmedLine.Contains("/>") || trimmedLine.Contains("</seealso>")))
407+
if (trimmedLine.StartsWith("<seealso", StringComparison.Ordinal) &&
408+
(trimmedLine.IndexOf("/>", StringComparison.Ordinal) >= 0 ||
409+
trimmedLine.IndexOf("</seealso>", StringComparison.Ordinal) >= 0))
408410
{
409411
// seealso tags go outside summary - save for later
410412
seeAlsoLines.Add(line.Trim());
@@ -472,7 +474,7 @@ private static string KeyToConstName(string key, string[]? productNames = null,
472474
{
473475
foreach (var productName in productNames)
474476
{
475-
if (pascalName!.Length > productName.Length &&
477+
if (pascalName.Length > productName.Length &&
476478
pascalName.StartsWith(productName, StringComparison.InvariantCulture))
477479
{
478480
pascalName = pascalName.Substring(productName.Length);

tracer/test/Datadog.Trace.SourceGenerators.Tests/ConfigurationKeysGeneratorTests.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -324,7 +324,7 @@ public void HandlesInvalidJson()
324324
}
325325

326326
[Fact]
327-
public void SortsEntriesAlphabetically()
327+
public void SortsEntriesAlphabeticallyByEnvironmentVariable()
328328
{
329329
const string supportedConfigJson = """
330330
{

0 commit comments

Comments
 (0)