Skip to content

Commit b9a2c0e

Browse files
authored
Fix the verify_app_trimming_changes_are_persisted job (#7542)
## Summary of changes Fixes the `verify_app_trimming_changes_are_persisted` job ## Reason for change The trimming job is currently trying to build the native code, but [we're getting this error](https://github.com/DataDog/dd-trace-dotnet/actions/runs/17909695789/job/50921858072?pr=7287): ``` C:\Program Files\Microsoft Visual Studio\2022\Enterprise\MSBuild\Microsoft\VC\v170\Microsoft.Cpp.WindowsSDK.targets(46,5): error MSB8036: The Windows SDK version 10.0.19041.0 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution". ``` We only need to build the managed code to regenerate the trimming file, so fix that ## Implementation details `BuildTracerHome` -> `BuildManagedTracerHome` ## Test coverage If this PR passes, we're good ## Other details Blocking CI in general
1 parent 6a6d4e9 commit b9a2c0e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/verify_app_trimming_changes_are_persisted.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ jobs:
2626
run: Get-ChildItem –Path ".\tracer\src\Datadog.Trace.Trimming\build\Datadog.Trace.Trimming.xml" -Recurse -File | Remove-Item
2727

2828
- name: "Regenerating Datadog.Trace.Trimming.xml"
29-
run: .\tracer\build.ps1 BuildTracerHome CreateTrimmingFile
29+
run: .\tracer\build.ps1 CreateRequiredDirectories Restore CompileManagedLoader CompileManagedSrc CreateTrimmingFile
3030

3131
- name: "Verify no changes in Datadog.Trace.Trimming.xml"
3232
run: |

0 commit comments

Comments
 (0)